Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(baremetal): add message signing contract #4407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Jan 8, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@github-actions github-actions bot added apple-silicon Apple Silicon issues, bugs and feature requests baremetal labels Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.69%. Comparing base (5bf53e0) to head (c7a037f).
Report is 427 commits behind head on master.

Files with missing lines Patch % Lines
.../namespaces/applesilicon/v1alpha1/custom_server.go 11.11% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4407      +/-   ##
==========================================
- Coverage   75.45%   70.69%   -4.77%     
==========================================
  Files         202      297      +95     
  Lines       44323    65890   +21567     
==========================================
+ Hits        33444    46578   +13134     
- Misses       9653    17669    +8016     
- Partials     1226     1643     +417     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di force-pushed the baremetal-signing-contract branch from 0736725 to c7a037f Compare January 8, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple-silicon Apple Silicon issues, bugs and feature requests baremetal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants