Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(block): add volume wait command #4434

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jan 15, 2025

It would be great to be able to wait for a volume to be detached. Some of our instance's tests currently use instance volume wait but will need this new command when we switch to sbs volumes.

@Codelax Codelax added enhancement sbs Scaleway Block Storage issues, bugs and feature requests labels Jan 15, 2025
@Codelax Codelax requested a review from remyleone as a code owner January 15, 2025 16:18
@Codelax Codelax force-pushed the feat/block-volume-wait branch from 8ac82f9 to 2a556d2 Compare January 15, 2025 16:19
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.72%. Comparing base (5bf53e0) to head (a0f3733).
Report is 442 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/namespaces/block/v1alpha1/custom_volume.go 53.84% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4434      +/-   ##
==========================================
- Coverage   75.45%   70.72%   -4.73%     
==========================================
  Files         202      298      +96     
  Lines       44323    66078   +21755     
==========================================
+ Hits        33444    46734   +13290     
- Misses       9653    17698    +8045     
- Partials     1226     1646     +420     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax force-pushed the feat/block-volume-wait branch from 063f01f to a0f3733 Compare January 15, 2025 16:45
@remyleone remyleone added this pull request to the merge queue Jan 17, 2025
Merged via the queue into scaleway:master with commit 93b5c42 Jan 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement sbs Scaleway Block Storage issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants