Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container/serverless): add scaling_option block #2876

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nullabe
Copy link

@nullabe nullabe commented Jan 15, 2025

Description

A new ScalingOption object was added to containers. It replace current max_concurrency. The old field should be marked as deprecated while adding the new object.

API Reference: https://www.scaleway.com/en/developers/api/serverless-containers/#path-containers-create-a-new-container

New or Affected Resource(s)

  • scaleway_container

Terraform configuration

resource scaleway_container main {
    namespace_id = scaleway_container_namespace.main.id
    deploy = false
    
    scaling_option {
        concurrent_requests_threshold = 15
    }
}

Related issues

Notes for the reviewer(s)

  • Using scaling_option terraform configuration to be compliant with the API.
  • Acceptance tests from real calls have been created on both resource and data.
  • Documentation has been updated.
  • An error is thrown if the user setup more than one option (according to API this should not be possible).
  • Errors has not been checked with specific tests cases, it may be useful (but I don't know how to do it).

@github-actions github-actions bot added the container Container issues, bugs and feature requests label Jan 15, 2025
@nullabe nullabe force-pushed the feat/container_serverless_scaling_option_block branch from 7038930 to 375f243 Compare January 15, 2025 15:32
@nullabe nullabe force-pushed the feat/container_serverless_scaling_option_block branch from 375f243 to d04ca3f Compare January 15, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Container issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant