Improvement/arsn 375 chain backend imp deny #2187
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new implicitDeny logic to ChainBackend returns.
PLEASE NOTE:
I do not know what the initial requirement/intended functionality of this class is.
Thus, I am unsure of the expected 'isImplicit' result of the policy merging functionality in this interface.
What I can discern from the code is this:
checkPolicies
method is called. It returns an array of the authorisation results of the request for each client in the ChainBackend (by calling the checkPolicies functions of these clients).isAllowed === true
takes priority. I would've thought it would make sense to have Deny take priority here. This means I would change this line in the_mergePolicies
method:to this
However, the tests expect the current behaviour. Why?
What would be the expected behaviour from this for the
isImplicit
variable?Who would have this context? The code was initially created by Alex Chan after report by @rachedbenmustapha
Thanks for any feedback