Skip to content

Commit

Permalink
document a todo to handle
Browse files Browse the repository at this point in the history
  • Loading branch information
tcarmet committed Aug 1, 2024
1 parent ebdf1d5 commit 74c87c2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion bert_e/workflow/gitwaterflow/branches.py
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,8 @@ def _set_target_versions(self, dst_branch):
self.target_versions.append('%d.%d.%d' % (
major, minor, dev_branch.micro + offset))
elif dev_branch and dev_branch.has_minor is False:
# TODO: handle case with stab/x.y.z with no dev/x.y
# TODO: handle case with stab/x.y.z with no dev/x.y -> no need as stab/x.y.z cannot exist without a dev/x.y
# TODO: handle case where dev/1 and dev/1.0 exists (but no 1.0.0 tag) -> Should return 1.0.0 only
self.target_versions.append(f"{major}.{dev_branch.latest_minor + 1}.{dev_branch.micro + 1}")


Expand Down

0 comments on commit 74c87c2

Please sign in to comment.