COSI-46 expose metrics service in kubernetes and E2E test #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: COSI-46
Issue: COSI-46
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
@@ Coverage Diff @@
## feature/COSI-19-add-s3-and-iam-metrics #72 +/- ##
=======================================================================
Coverage 94.62% 94.62%
=======================================================================
Files 10 10
Lines 782 782
=======================================================================
Hits 740 740
Misses 36 36
Partials 6 6 |
Issue: COSI-46
anurag4DSB
force-pushed
the
feature/COSI-46-expose-metrics-service-in-kubernetes
branch
from
1e81b7e to
e477885
Compare
anurag4DSB
changed the title
anurag4DSB
force-pushed
the
feature/COSI-46-expose-metrics-service-in-kubernetes
branch
from
b1e6d12 to
7e74398
Compare
|
|
||
| log_and_run curl -f http://localhost:$LOCAL_PORT/metrics > metrics_output.txt | ||
|
|
||
| if [ $? -eq 0 ]; then |
There was a problem hiding this comment.
I think you might lose the curl return code with the pipe | tee
https://unix.stackexchange.com/a/14276
Comment on lines
+22
to
+25
| # Log command execution to the log file for debugging | ||
| log_and_run() { | ||
| "$@" 2>&1 | tee -a "$LOG_FILE" | ||
| } |
There was a problem hiding this comment.
Could this be replaced with the set -x option on bash
| ports: | ||
| - protocol: TCP | ||
| port: {{ .Values.metrics.port }} | ||
| targetPort: {{ .Values.metrics.port }} |
There was a problem hiding this comment.
missing newline at end of some files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E tests are facing some issues, which I am debugging. But still reviewable.
This pull request introduces several changes to enable and configure metrics collection for the Scality COSI driver. The main changes include adding a new metrics service, updating deployment configurations to expose metrics, and modifying CI workflows to include metrics testing. This includes E2E tests
Metrics Collection Enablement:
New Metrics Service:
Servicedefinition for the metrics endpoint inhelm/scality-cosi-driver/templates/service.yaml.Deployment Configuration:
helm/scality-cosi-driver/templates/deployment.yamlto include Prometheus annotations and set the metrics address. [1] [2]kustomize/base/deployment.yamlto include Prometheus annotations and set the metrics address. [1] [2]CI Workflow Updates:
.github/scripts/e2e_tests_metrics_service.shto test metrics collection during CI runs..github/workflows/ci-e2e-tests.ymlto include the new metrics testing script in the E2E tests.RBAC Adjustments:
kustomize/base/rbac.yamlto include permissions for services and endpoints to support metrics collection.These changes collectively enable the Scality COSI driver to expose metrics that can be scraped by Prometheus, ensuring better observability and monitoring.