Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTESCA-13975 // Migration to React 18 #15

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Enhance FederatedComponent with generic props for shell hooks…
… and alerts"

This reverts commit d5d651c.
  • Loading branch information
hervedombya committed Nov 26, 2024
commit 8f26a06f1c7d0ed1cf322afd75de59e2a070c883
9 changes: 2 additions & 7 deletions src/ModuleFederation.tsx
Original file line number Diff line number Diff line change
@@ -67,11 +67,6 @@ export type FederatedComponentProps = {
module: string;
};

export type FederateAppProps<T, U> = {
shellHooks: T;
shellAlerts: U;
};

export type SolutionUI = {
kind: string;
url: string;
@@ -80,15 +75,15 @@ export type SolutionUI = {
appHistoryBasePath: string;
};

export function FederatedComponent<T, U>({
export function FederatedComponent({
url,
scope,
module,
app,
renderOnLoading,
props,
}: FederatedComponentProps & {
props: FederateAppProps<T, U>;
props: any;
app: SolutionUI;
renderOnLoading?: ReactNode;
}) {