Skip to content

Commit

Permalink
Expose os and arch param for BaseRunnerGroup (#651)
Browse files Browse the repository at this point in the history
- The config params loaded in
[settings](https://github.com/scality/runner-manager/blob/main/runner_manager/models/settings.py#L33)
maps to the
[BaseRunnerGroup](https://github.com/scality/runner-manager/blob/main/runner_manager/models/runner_group.py#L32)
.
- Added `os` and `arch` params to the BaseRunnerGroup in order to
configure them through the config yaml.
- This is required for filtering the
[download_url](https://github.com/scality/runner-manager/blob/main/runner_manager/models/runner_group.py#L130)
  • Loading branch information
monabhardwaj authored Jul 22, 2024
1 parent 99a4199 commit 137f4a6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions runner_manager/models/runner_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ class BaseRunnerGroup(PydanticBaseModel):
runners: Optional[List[int]] = None
max: Optional[int] = Field(ge=1, default=20)
min: Optional[int] = Field(ge=0, default=0)
os: str = Field(default="linux")
arch: str = Field(default="x64")
labels: List[str]
job_started_script: Optional[str] = ""
job_completed_script: Optional[str] = ""
Expand Down

0 comments on commit 137f4a6

Please sign in to comment.