Support allow_public_repo on github group config (#437)

scality · Oct 3, 2023 · 22de028 · 22de028
1 parent aa047e8
commit 22de028
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/runner_manager/clients/github.py b/runner_manager/clients/github.py
@@ -146,7 +146,8 @@ def update_self_hosted_runner_group_for_org(
     ) -> Response[RunnerGroup]:
         url = f"/orgs/{org}/actions/runner-groups/{runner_group_id}"
 
-        json = data.dict(exclude_unset=True) if data else None
+        # exclude id from data
+        json = data.dict(exclude_unset=True, exclude={"id"}) if data else None
 
         headers = {"X-GitHub-Api-Version": self._REST_API_VERSION, **(headers or {})}
 

diff --git a/runner_manager/models/runner_group.py b/runner_manager/models/runner_group.py
@@ -224,6 +224,7 @@ def create_github_group(self, github: GitHub) -> GitHubRunnerGroup:
         data = GitHubRunnerGroup(
             name=self.name,
             default=self.default,
+            allows_public_repositories=self.allows_public_repositories,
         )
         if self.id is None:
             group = github.rest.actions.create_self_hosted_runner_group_for_org(