PTFE-675: gcp backend labels

scality · Aug 14, 2023 · ec7e188 · ec7e188
1 parent 8a9e25e
commit ec7e188
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/runner_manager/backend/gcloud.py b/runner_manager/backend/gcloud.py
@@ -89,9 +89,9 @@ def get_network_interfaces(self) -> List[NetworkInterface]:
         ]
 
     def create(self, runner: Runner):
-        labels: Dict[str, str] = {
-            "runner-manager": self.manager,
-        }
+        labels: Dict[str, str] = {}
+        if self.manager:
+            labels["runner-manager"] = self.manager
         try:
             image = self.get_image()
             disks = self.get_disks()

diff --git a/tests/unit/backend/test_gcp.py b/tests/unit/backend/test_gcp.py
@@ -11,7 +11,7 @@
 
 
 @fixture()
-def gcp_group() -> RunnerGroup:
+def gcp_group(settings) -> RunnerGroup:
     config = GCPConfig(
         project_id=os.environ.get("CLOUDSDK_CORE_PROJECT", ""),
         zone=os.environ.get("CLOUDSDK_COMPUTE_ZONE", ""),
@@ -23,6 +23,7 @@ def gcp_group() -> RunnerGroup:
         id=2,
         name="test",
         organization="test",
+        manager=settings.name,
         backend=GCPBackend(
             name=Backends.gcloud,
             config=config,