PTFE-1577 Ensure ec2 instance volume are tagged accordingly

scality · Apr 2, 2024 · fb0b01a · fb0b01a
1 parent 87e8ea2
commit fb0b01a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/runner_manager/models/backend.py b/runner_manager/models/backend.py
@@ -171,13 +171,17 @@ def configure_instance(self, runner: Runner) -> AwsInstance:
                     VolumeType=self.volume_type,
                     VolumeSize=self.disk_size_gb,
                     DeleteOnTermination=True,
-                ),
+                )
             )
         ]
         tags_specification: Sequence[TagSpecificationTypeDef] = [
             TagSpecificationTypeDef(
                 ResourceType="instance",
                 Tags=tags,
+            ),
+            TagSpecificationTypeDef(
+                ResourceType="volume",
+                Tags=tags,
             )
         ]
         return AwsInstance(

diff --git a/tests/unit/backend/test_aws.py b/tests/unit/backend/test_aws.py
@@ -56,6 +56,7 @@ def test_aws_instance_config(runner: Runner):
     assert TagTypeDef(Key="test", Value="test") in tags
     assert TagTypeDef(Key="Name", Value=runner.name) in tags
     assert runner.encoded_jit_config in instance["UserData"]
+    assert instance["TagSpecifications"][1]["ResourceType"] == "volume"
 
 
 @mark.skipif(not os.getenv("AWS_ACCESS_KEY_ID"), reason="AWS credentials not found")