Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTFE-544: kustomize runner manager #270

Merged
merged 16 commits into from
Jul 13, 2023
Merged

PTFE-544: kustomize runner manager #270

merged 16 commits into from
Jul 13, 2023

Conversation

Abubakarr99
Copy link
Contributor

No description provided.

@Abubakarr99 Abubakarr99 requested a review from a team as a code owner July 10, 2023 14:19
@Abubakarr99 Abubakarr99 marked this pull request as draft July 10, 2023 15:11
tcarmet
tcarmet requested changes Jul 10, 2023
View reviewed changes
manifests/base/deployment.yaml Outdated Show resolved Hide resolved
manifests/base/redis.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager-auth.env Outdated Show resolved Hide resolved
manifests/base/service.yaml Outdated Show resolved Hide resolved
manifests/base/kustomization.yaml Outdated Show resolved Hide resolved
Abubakarr99
Abubakarr99 commented Jul 11, 2023
View reviewed changes
manifests/base/runner-manager/deployment.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/service.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/service.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/service.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/service.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/service.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/service.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/kustomization.yaml Outdated Show resolved Hide resolved
manifests/base/redis/redis.yaml Outdated Show resolved Hide resolved
tcarmet
tcarmet reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking pretty good, now my question is does it work?
Are you able to deploy it in a kind cluster?

manifests/base/redis/redis.yaml Outdated Show resolved Hide resolved
manifests/base/redis/redis-secrets.env Outdated Show resolved Hide resolved
manifests/base/redis/redis.yaml Outdated Show resolved Hide resolved
manifests/base/redis/redis.yaml Outdated Show resolved Hide resolved
manifests/base/redis/redis.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/deployment.yaml Outdated Show resolved Hide resolved
manifests/base/runner-manager/deployment.yaml Outdated Show resolved Hide resolved
@Abubakarr99 Abubakarr99 requested a review from tcarmet July 12, 2023 15:54
@Abubakarr99 Abubakarr99 marked this pull request as ready for review July 12, 2023 15:54
@codecov-commenter
Copy link

Codecov Report

Merging #270 (108fdcf) into main (374f01a) will decrease coverage by 0.45%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   71.98%   71.54%   -0.45%     
==========================================
  Files          15       15              
  Lines         846      861      +15     
==========================================
+ Hits          609      616       +7     
- Misses        237      245       +8
Impacted Files Coverage Δ
srcs/runners_manager/runner/RedisManager.py 69.64% <16.66%> (-6.36%) ⬇️
..._manager/vm_creation/openstack/OpenstackManager.py 31.19% <50.00%> (+0.35%) ⬆️
srcs/runners_manager/vm_creation/CloudManager.py 58.18% <66.66%> (+0.48%) ⬆️
srcs/runners_manager/runner/RunnerManager.py 91.13% <75.00%> (-0.87%) ⬇️

tcarmet
tcarmet reviewed Jul 12, 2023
View reviewed changes
manifests/base/redis/redis.yaml Outdated Show resolved Hide resolved
manifests/kustomization.yaml Outdated Show resolved Hide resolved
manifests/base/redis/kustomization.yaml Show resolved Hide resolved
manifests/base/runner-manager/kustomization.yaml Show resolved Hide resolved
manifests/base/redis/redis.yaml Outdated Show resolved Hide resolved
tcarmet
tcarmet approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments are pretty minor, so LGTM

Abubakarr99 and others added 2 commits July 13, 2023 14:43
@Abubakarr99 Abubakarr99 merged commit e5e98e5 into main Jul 13, 2023
12 of 13 checks passed
@Abubakarr99 Abubakarr99 deleted the feature/PTFE-544-kustomize-runner-manager branch July 13, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmet tcarmet tcarmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abubakarr99 @codecov-commenter @tcarmet