Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTFE-584 bootstrap project design and structure #288

Merged
merged 26 commits into from
Jul 27, 2023
Merged

PTFE-584 bootstrap project design and structure #288

merged 26 commits into from
Jul 27, 2023

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Jul 25, 2023 •
edited
Loading

Initial design for upcoming 1.0 project's release.

@tcarmet tcarmet marked this pull request as ready for review July 25, 2023 22:36
@tcarmet tcarmet requested a review from a team as a code owner July 25, 2023 22:36
gaspardmoindrot
gaspardmoindrot suggested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@gaspardmoindrot gaspardmoindrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's amazing the work you've done, it's super clean, especially the documentation. Since it's just the beginning of the work, I don't necessarily have additional things to say as there are still many things to do.

Dockerfile Show resolved Hide resolved
docs/development/code.md Outdated Show resolved Hide resolved
docs/development/code.md Outdated Show resolved Hide resolved
docs/development/concepts.md Outdated Show resolved Hide resolved
docs/development/configuration.md Outdated Show resolved Hide resolved
docs/development/workflows.md Outdated Show resolved Hide resolved
docs/development/workflows.md Show resolved Hide resolved
docs/development/workflows.md Show resolved Hide resolved
runner_manager/models/runner.py Outdated Show resolved Hide resolved
tests/images/github-mock/Dockerfile Outdated Show resolved Hide resolved
@tcarmet
Apply suggestions from code review
ddc31cb 
Co-authored-by: gaspardmoindrot <[email protected]>
tcarmet
tcarmet commented Jul 26, 2023
View reviewed changes
docs/development/configuration.md Outdated Show resolved Hide resolved
docs/development/configuration.md Outdated Show resolved Hide resolved
docs/development/environment.md Show resolved Hide resolved
docs/development/workflows.md Show resolved Hide resolved
runner_manager/models/runner.py Outdated Show resolved Hide resolved
gaspardmoindrot
gaspardmoindrot approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@gaspardmoindrot gaspardmoindrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, if there are some changes, tell me and I'll do another review

@tcarmet tcarmet merged commit 9673938 into main Jul 27, 2023
3 checks passed
@tcarmet tcarmet deleted the feature/PTFE-584-bootstrap-design-1.0 branch July 27, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaspardmoindrot gaspardmoindrot gaspardmoindrot approved these changes

@Abubakarr99 Abubakarr99 Awaiting requested review from Abubakarr99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcarmet @gaspardmoindrot