Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-693: unit test for settings class #309

Merged
merged 22 commits into from
Aug 4, 2023

Conversation

Abubakarr99
Copy link
Contributor

No description provided.

@Abubakarr99 Abubakarr99 requested a review from a team as a code owner August 2, 2023 11:19
tests/unit/models/test_settings.py Outdated Show resolved Hide resolved
tests/unit/models/test_settings.py Outdated Show resolved Hide resolved
tests/unit/models/test_settings.py Outdated Show resolved Hide resolved
@Abubakarr99 Abubakarr99 marked this pull request as draft August 2, 2023 15:15
@Abubakarr99 Abubakarr99 marked this pull request as ready for review August 3, 2023 08:46
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally add a testcase with errors expecting to be raised:

What happens when you do:

Settings(redis_om_url="toto")

Can be tested like:

with pytest.raises(<expected exception>):
    Settings(redis_om_url="toto")

tests/unit/models/test_settings.py Outdated Show resolved Hide resolved
tests/unit/models/test_settings.py Outdated Show resolved Hide resolved
tests/unit/models/test_settings.py Show resolved Hide resolved
tests/unit/models/test_settings.py Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #309 (f49805f) into main (5c1af0b) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   90.04%   90.47%   +0.43%     
==========================================
  Files          13       13              
  Lines         231      231              
==========================================
+ Hits          208      209       +1     
+ Misses         23       22       -1     
Flag Coverage Δ
api 19.91% <50.00%> (ø)
unit 81.81% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
runner_manager/models/settings.py 100.00% <100.00%> (+4.54%) ⬆️

@tcarmet tcarmet enabled auto-merge (squash) August 4, 2023 22:39
@tcarmet tcarmet merged commit 6be84b1 into main Aug 4, 2023
11 checks passed
@tcarmet tcarmet deleted the feature/PTFE-693-unit-test-settings branch August 4, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants