Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTFE-681] Fastapi router routes #312

Merged
merged 9 commits into from
Aug 4, 2023

Conversation

gaspardmoindrot
Copy link
Contributor

No description provided.

@gaspardmoindrot gaspardmoindrot self-assigned this Aug 2, 2023
@gaspardmoindrot gaspardmoindrot requested a review from a team as a code owner August 2, 2023 19:01
@gaspardmoindrot gaspardmoindrot marked this pull request as draft August 2, 2023 19:01
@gaspardmoindrot gaspardmoindrot marked this pull request as ready for review August 3, 2023 16:21
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests?

tests/api/test_job.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #312 (1396700) into main (ca1b99f) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   89.73%   90.04%   +0.31%     
==========================================
  Files          12       13       +1     
  Lines         224      231       +7     
==========================================
+ Hits          201      208       +7     
  Misses         23       23              
Flag Coverage Δ
api 19.91% <100.00%> (+2.50%) ⬆️
unit 81.38% <0.00%> (-2.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
runner_manager/main.py 76.47% <100.00%> (+3.13%) ⬆️
runner_manager/routers/webhook.py 100.00% <100.00%> (ø)

@tcarmet tcarmet merged commit e4f79a6 into main Aug 4, 2023
11 checks passed
@tcarmet tcarmet deleted the improvement/PTFE-681-fastapi-router-routes branch August 4, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants