Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-679 implementing webhook endpoint and authentication #332

Merged
merged 7 commits into from
Aug 9, 2023

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Aug 8, 2023

No description provided.

@tcarmet tcarmet marked this pull request as ready for review August 8, 2023 23:30
@tcarmet tcarmet requested a review from a team as a code owner August 8, 2023 23:30
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #332 (ac1df02) into main (8be87fd) will increase coverage by 0.03%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   91.77%   91.81%   +0.03%     
==========================================
  Files          14       16       +2     
  Lines         304      342      +38     
==========================================
+ Hits          279      314      +35     
- Misses         25       28       +3     
Flag Coverage Δ
api 23.39% <72.72%> (+8.26%) ⬆️
unit 78.65% <29.54%> (-7.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
runner_manager/jobs/webhook.py 66.66% <66.66%> (ø)
runner_manager/clients/github.py 100.00% <100.00%> (ø)
runner_manager/models/settings.py 100.00% <100.00%> (ø)
runner_manager/models/webhook.py 100.00% <100.00%> (ø)
runner_manager/routers/webhook.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@tcarmet tcarmet enabled auto-merge (squash) August 8, 2023 23:56
runner_manager/routers/webhook.py Outdated Show resolved Hide resolved
runner_manager/routers/webhook.py Outdated Show resolved Hide resolved
@tcarmet tcarmet disabled auto-merge August 9, 2023 18:10
@tcarmet tcarmet merged commit 459ad45 into main Aug 9, 2023
11 checks passed
@tcarmet tcarmet deleted the feature/PTFE-679-validate-webhooks branch August 9, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants