Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTFE-675 GCP backend #334

Merged
merged 14 commits into from
Aug 14, 2023
Merged

PTFE-675 GCP backend #334

merged 14 commits into from
Aug 14, 2023

Conversation

Abubakarr99
Copy link
Contributor

No description provided.

@Abubakarr99 Abubakarr99 requested a review from a team as a code owner August 9, 2023 15:47
@tcarmet tcarmet marked this pull request as draft August 9, 2023 18:21
@tcarmet tcarmet changed the title Feature/ptfe 675 gcp backend PTFE-675 GCP backend Aug 9, 2023
tcarmet
tcarmet requested changes Aug 10, 2023
View reviewed changes
runner_manager/backend/gcloud.py Outdated Show resolved Hide resolved
tests/unit/backend/test_gcp.py Outdated Show resolved Hide resolved
@Abubakarr99 Abubakarr99 marked this pull request as ready for review August 10, 2023 07:22
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #334 (4d31255) into main (3b21985) will decrease coverage by 10.34%.
The diff coverage is 41.88%.

@@             Coverage Diff             @@
##             main     #334       +/-   ##
===========================================
- Coverage   90.30%   79.96%   -10.34%     
===========================================
  Files          23       24        +1     
  Lines         433      549      +116     
===========================================
+ Hits          391      439       +48     
- Misses         42      110       +68
Flag Coverage Δ
api 59.92% <41.88%> (-4.97%) ⬇️
unit 63.57% <41.88%> (-5.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
runner_manager/backend/gcloud.py 29.47% <29.47%> (ø)
runner_manager/models/backend.py 97.61% <95.23%> (-2.39%) ⬇️
runner_manager/models/runner_group.py 92.15% <100.00%> (+0.15%) ⬆️

tcarmet
tcarmet requested changes Aug 10, 2023
View reviewed changes
runner_manager/backend/gcloud.py Outdated Show resolved Hide resolved
tests/unit/backend/test_gcp.py Outdated Show resolved Hide resolved
tests/unit/backend/test_gcp.py Show resolved Hide resolved
tcarmet
tcarmet reviewed Aug 10, 2023
View reviewed changes
runner_manager/models/backend.py Show resolved Hide resolved
runner_manager/models/backend.py Outdated Show resolved Hide resolved
runner_manager/backend/gcloud.py Outdated Show resolved Hide resolved
tcarmet
tcarmet approved these changes Aug 11, 2023
View reviewed changes
runner_manager/backend/gcloud.py Outdated Show resolved Hide resolved
runner_manager/models/backend.py Show resolved Hide resolved
runner_manager/models/backend.py Outdated Show resolved Hide resolved
@Abubakarr99 Abubakarr99 merged commit ec7b24a into main Aug 14, 2023
10 of 11 checks passed
@Abubakarr99 Abubakarr99 deleted the feature/PTFE-675-gcp-backend branch August 14, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmet tcarmet tcarmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abubakarr99 @codecov-commenter @tcarmet