PTFE-1575 Upgrade githubkit to latest version #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmet
force-pushed
the
bugfix/upgrade-githubkit
branch
5 times, most recently
from
72360ba
to
f3302e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
===========================================
+ Coverage 67.71% 85.95% +18.23%
===========================================
Files 31 31
Lines 1211 1210 -1
===========================================
+ Hits 820 1040 +220
+ Misses 391 170 -221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tcarmet
force-pushed
the
bugfix/upgrade-githubkit
branch
2 times, most recently
from
e6f0ad2
to
0e20268
Compare
tcarmet
force-pushed
the
bugfix/upgrade-githubkit
branch
from
0e20268
to
c38afc5
Compare
tcarmet
changed the title
nootal
approved these changes
Mar 20, 2024
tcarmet
added a commit
that referenced
this pull request
Apr 2, 2024
…tamp (#564) Following #555, an assertion error was occuring due to the assumption that both the `created_at` and `started_at` fields in the `workflow_job` webhooks were `datetime` instead of `str`. This, following the pattern in #555, converts the `str` value of the webhook into `datetime` before the assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub most likely made some updates and small tweaks to the data it sends with webhook, and the runner-manager is currently raising some 422 errors when receiving some of them.
Updating githubkit to the latest version available to benefit from the latest changes/updates within GitHub's API.