webhook: fix non-matching webhook secrets not being rejected #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not familiar with FastAPI at all so if there is a better way of getting the request body without having to add |
tcarmet
approved these changes
May 15, 2024
There was a problem hiding this comment.
Thanks for providing this very valuable fix!
I don't have enough knowledge as well into why we have to use async to make this code works, but given that you have provided the appropriate test case and it is covered, and I know that using async with FastAPI is usually the way to go so LGTM and thanks again ❤️ !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue which allowed webhooks to be processed with an incorrect webhook secret.
This adds a case to return a
401when theverifyfunction returns false. Theverifyfunction also always returns false as it is being passed in JSON from aWorkflowJobwebhook object instead of the request body (which is how GitHub generates it's signitures) meaning the signatures will never match (see https://github.com/yanyongyu/githubkit?tab=readme-ov-file#webhook-verification).