Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add endpoint to list runners #629

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

lewismiddleton
Copy link
Contributor

@lewismiddleton lewismiddleton commented Jul 8, 2024

Adds an endpoint at /groups/{name}/list to list the runners in each runner group .

Relates to #625

@lewismiddleton lewismiddleton requested a review from a team as a code owner July 8, 2024 11:28
@lewismiddleton
Copy link
Contributor Author

This implementation causes the encoded_jit_config to be exported as JSON. This could be a security risk in that it may allow someone with access to the runner-manager endpoint to register a runner using the same config.

I did some testing locally and I wasn't able to register a new runner using the same encoded_jit_config but I don't have high confidence that will always be the case.

Adds an endpoint to list the runners in each runner group under
`/groups/{name}/list`.
@lewismiddleton
Copy link
Contributor Author

Trying to remove the encoded_jit_config from the output in df057a2 worked in the test suite but still outputted jit_config when deployed in a live environment. Unsure why that's the case.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (b83bf37) to head (f0c995e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   86.43%   86.52%   +0.08%     
==========================================
  Files          33       33              
  Lines        1386     1395       +9     
==========================================
+ Hits         1198     1207       +9     
  Misses        188      188              
Flag Coverage Δ
api 64.08% <100.00%> (+0.23%) ⬆️
unit 68.31% <0.00%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet merged commit 94e45c1 into scality:main Jul 10, 2024
9 of 11 checks passed
@lewismiddleton lewismiddleton deleted the runners-endpoint branch September 23, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants