Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for referrencing image name on gcp backend #654

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Jul 22, 2024

No description provided.

@tcarmet tcarmet requested a review from a team as a code owner July 22, 2024 21:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (5ff35da) to head (9da7326).

✅ All tests successful. No failed tests found.

Files Patch % Lines
runner_manager/backend/gcloud.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   86.77%   86.66%   -0.12%     
==========================================
  Files          34       34              
  Lines        1422     1425       +3     
==========================================
+ Hits         1234     1235       +1     
- Misses        188      190       +2     
Flag Coverage Δ
api 65.12% <33.33%> (-0.07%) ⬇️
unit 67.64% <33.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet merged commit 28fe200 into main Jul 22, 2024
12 checks passed
@tcarmet tcarmet deleted the feature/support-image-config-gcp branch July 22, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants