Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job hook scripts pre-emptively expands shell parameters #686

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

harryfinbow
Copy link
Contributor

The job_started_script and job_completed_script pre-emptively expand any shell parameters defined in them, resulting in them being expanded when the /opt/runner/job_started_script.sh and /opt/runner/job_completed_script.sh files are created and not at runtime of the job.

Instructing the heredoc document to skip expanding any shell parameters gives the expected functionality without having to escape them in the config file.

@harryfinbow harryfinbow requested a review from a team as a code owner October 7, 2024 13:09
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (e9a7d28) to head (0947e6c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   86.68%   86.68%           
=======================================
  Files          35       35           
  Lines        1510     1510           
=======================================
  Hits         1309     1309           
  Misses        201      201           
Flag Coverage Δ
api 63.90% <ø> (ø)
unit 68.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet merged commit 01ecaae into scality:main Oct 7, 2024
18 of 19 checks passed
@harryfinbow harryfinbow deleted the escape-startup-complete-scripts branch October 7, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants