ARTESCA-11662: trigger veeam assistant from account list page #741

ChengYanJin · 2024-03-18T17:06:46Z

Light theme:

Dark theme:

bert-e · 2024-03-18T17:06:50Z

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-03-18T17:06:54Z

Conflict

There is a conflict between your branch feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page and the
destination branch development/2.2.

Please resolve the conflict on the feature branch (feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page).

git fetch && \
git checkout origin/feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page && \
git merge origin/development/2.2

Resolve merge conflicts and commit

git push origin HEAD:feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page

bert-e · 2024-03-18T17:08:01Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-03-19T12:08:55Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-03-19T15:53:02Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

codecov-commenter · 2024-03-19T16:32:01Z

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 59.40%. Comparing base (3dc42b6) to head (14473a0).

Files	Patch %	Lines
src/react/account/AccountList.tsx	66.66%	2 Missing ⚠️
src/react/ui-elements/Veeam/VeeamConfiguration.tsx	90.00%	2 Missing ⚠️
src/react/ui-elements/Veeam/VeeamSummary.tsx	75.00%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/2.2     #741      +/-   ##
===================================================
+ Coverage            59.39%   59.40%   +0.01%     
===================================================
  Files                  240      240              
  Lines                11320    11347      +27     
  Branches              3266     3281      +15     
===================================================
+ Hits                  6723     6741      +18     
- Misses                4576     4585       +9     
  Partials                21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/react/ui-elements/Veeam/VeeamConfiguration.test.tsx

src/react/ui-elements/Veeam/VeeamConfiguration.tsx

bert-e · 2024-03-21T10:02:21Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin · 2024-03-21T10:59:33Z

/approve

bert-e · 2024-03-21T10:59:38Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

hervedombya

LGTM !

bert-e · 2024-03-21T11:07:22Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.2

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2024-03-21T11:07:30Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.2

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1

Please check the status of the associated issue ARTESCA-11662.

Goodbye chengyanjin.

JBWatenbergScality · 2024-03-25T14:13:45Z

src/react/ui-elements/Veeam/VeeamConfiguration.tsx

+  const decimalCount = num.toString().split('.')[1]?.length || 0;
+  return decimalCount > 1;


Math.floor(num*10) === num*10

ChengYanJin force-pushed the feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page branch from 05c8428 to 00f2421 Compare March 18, 2024 17:07

ChengYanJin force-pushed the feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page branch from 00f2421 to 36a3ceb Compare March 18, 2024 17:11

ChengYanJin force-pushed the feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page branch from 9ed2e04 to 6b15cdb Compare March 19, 2024 16:25

ChengYanJin marked this pull request as ready for review March 19, 2024 16:38

ChengYanJin added 5 commits March 20, 2024 11:52

Add veeam retrigger in the account page

5e9c033

Add Account field in the Veeam configuration form

61b41f7

Fix all the test for Veeam following the change of retrigger

37020eb

Add test for the Veeam configuration form

434fd20

Veeam Assistant UI polish

363ede4

hervedombya reviewed Mar 20, 2024

View reviewed changes

src/react/ui-elements/Veeam/VeeamConfiguration.test.tsx Outdated Show resolved Hide resolved

hervedombya reviewed Mar 20, 2024

View reviewed changes

src/react/ui-elements/Veeam/VeeamConfiguration.tsx Outdated Show resolved Hide resolved

ChengYanJin force-pushed the feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page branch 3 times, most recently from 75fa8fb to b47a9c1 Compare March 20, 2024 20:48

ChengYanJin added 2 commits March 20, 2024 22:45

Fix the access denied by adding token in the queryKey

ebb14bc

Add Veeam logo in the form

a63519e

ChengYanJin force-pushed the feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page branch from b47a9c1 to cf8aecd Compare March 20, 2024 21:48

ChengYanJin added 2 commits March 20, 2024 22:58

keep one decimal for the max repository capacity

08bcedf

Address some small comments

14473a0

ChengYanJin force-pushed the feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page branch from 8a0fd3b to 14473a0 Compare March 20, 2024 21:58

Add precision validation for capacity field in VeeamConfiguration.tsx

f9f67f0

Add test to cover the max capacity to only one decimal

d0ae641

ChengYanJin force-pushed the feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page branch from 867c61e to d0ae641 Compare March 21, 2024 11:01

hervedombya approved these changes Mar 21, 2024

View reviewed changes

bert-e merged commit d0ae641 into development/2.2 Mar 21, 2024
15 checks passed

bert-e deleted the feature/ARTESCA-11662-trigger-veeam-assistant-from-account-list-page branch March 21, 2024 11:07

JBWatenbergScality reviewed Mar 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARTESCA-11662: trigger veeam assistant from account list page #741

ARTESCA-11662: trigger veeam assistant from account list page #741

ChengYanJin commented Mar 18, 2024 •

edited

Loading

bert-e commented Mar 18, 2024

bert-e commented Mar 18, 2024

bert-e commented Mar 18, 2024

bert-e commented Mar 19, 2024

bert-e commented Mar 19, 2024

codecov-commenter commented Mar 19, 2024 •

edited

Loading

bert-e commented Mar 21, 2024

ChengYanJin commented Mar 21, 2024

bert-e commented Mar 21, 2024

hervedombya left a comment

bert-e commented Mar 21, 2024

bert-e commented Mar 21, 2024

JBWatenbergScality Mar 25, 2024 •

edited

Loading

		const decimalCount = num.toString().split('.')[1]?.length \|\| 0;
		return decimalCount > 1;

ARTESCA-11662: trigger veeam assistant from account list page #741

ARTESCA-11662: trigger veeam assistant from account list page #741

Conversation

ChengYanJin commented Mar 18, 2024 • edited Loading

bert-e commented Mar 18, 2024

Hello chengyanjin,

bert-e commented Mar 18, 2024

Conflict

bert-e commented Mar 18, 2024

Waiting for approval

bert-e commented Mar 19, 2024

Waiting for approval

bert-e commented Mar 19, 2024

Waiting for approval

codecov-commenter commented Mar 19, 2024 • edited Loading

Codecov Report

bert-e commented Mar 21, 2024

Waiting for approval

ChengYanJin commented Mar 21, 2024

bert-e commented Mar 21, 2024

Waiting for approval

hervedombya left a comment

Choose a reason for hiding this comment

bert-e commented Mar 21, 2024

In the queue

bert-e commented Mar 21, 2024

JBWatenbergScality Mar 25, 2024 • edited Loading

Choose a reason for hiding this comment

ChengYanJin commented Mar 18, 2024 •

edited

Loading

codecov-commenter commented Mar 19, 2024 •

edited

Loading

JBWatenbergScality Mar 25, 2024 •

edited

Loading