Catch-all rules in the Gateway #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbiehl
commented
Feb 15, 2024
| -- adjustment. | ||
| let encodedSegments = | ||
| foldr | ||
| (\x -> ((char7 '/' <> urlEncodeBuilder True (Text.encodeUtf8 x)) <>)) |
There was a problem hiding this comment.
We've been bitten by this in the past. It's a little bit more involved than just calling some function to encode the url segments but this way we are encoding them with max. escaping now.
justinwoo
approved these changes
Feb 15, 2024
ken-scarf
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a first class Catch-All rule. This is really a general redirect that rewrites the host of the request to a target domain and redirects to it.
This is meant to be an alternative to the various
/{+path}catch-all file packages that we have around. Since URI template are not expressive enough to model the encoding requirements for some requests we introducing this new rule type.