fix(buttons): buttons on mac are out of screen #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Morgan-6Freedom
commented
Jan 9, 2024
•
Morgan-6Freedom
commented
- Screen width is divided by two if on MacOs because of retina displays
- reduce the middle section width
- button color are fixed
- put the color buttons on a fixed 4 columns
Screen width is divided by two if on MacOs because of retina displays
|
Funnctionally fine for me I let @mrbusysky have a look to the code and if there is any regression on windows |
Morgan-6Freedom
changed the title
nbrucker
reviewed
Jan 9, 2024
|
LGTM, other than the issue pointed out above. Also, we usually remove comments. |
mrbusysky
approved these changes
Jan 10, 2024
Morgan-6Freedom
deleted the
89-on-mac-buttons-are-out-of-the-screen-and-without-colors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.