fix(versionumber): the updateversionfrompackagejson function should not use a static path #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it now use a dynamic path based on the assembly definition
Morgan-6Freedom
changed the title
Morgan-6Freedom
changed the title
|
Does it take the version number from Scenario/package.json, or root package.json? Is this version number used only to be displayed on settings? |
Yes it is only used there.
It takes the version number from the same file as before : Scenario/package.json Why is there two of them ? |
|
The on at the root level is the one of the repo with dev dependencies and repo version for release numbers and tag. The issue we have is that the one at the root level is automatically updated by the CI when we release, but not the one in Scenario folder. Can we merge both to have everything at root level? |
|
I think it would make more sense to only have one. |
|
If #106 this PR pass, this one will be out of date. |
…tion-should-not-use-a-static-path
|
@qvaleroo this is now ok from develop. Can merge into dev |
qvaleroo
approved these changes
Jan 22, 2024
qvaleroo
deleted the
102-the-updateversionfrompackagejson-function-should-not-use-a-static-path
branch
qvaleroo
added a commit
that referenced
this pull request
Jan 26, 2024
* feat(package)!: the repo is now a unity package (#106) * move every files in correct folder * added & rename asmdef * fix readme * Update package.json * fix: assembly definition * feat!: change the folders architecture * Create .gitignore * feat: update the readme to explain how to install * fix: remove deeplink WIP * fix(versionumber): the updateversionfrompackagejson function should not use a static path (#103) * change to a dynamic path it now use a dynamic path based on the assembly definition * fix: because the folder structure have changed * chore: upgrade version --------- Co-authored-by: Morgan - 6 Freedom <[email protected]>
qvaleroo
added a commit
that referenced
this pull request
Jan 26, 2024
* Release to download the repo from GitHub URL (#110) * feat(package)!: the repo is now a unity package (#106) * move every files in correct folder * added & rename asmdef * fix readme * Update package.json * fix: assembly definition * feat!: change the folders architecture * Create .gitignore * feat: update the readme to explain how to install * fix: remove deeplink WIP * fix(versionumber): the updateversionfrompackagejson function should not use a static path (#103) * change to a dynamic path it now use a dynamic path based on the assembly definition * fix: because the folder structure have changed * chore: upgrade version --------- Co-authored-by: Morgan - 6 Freedom <[email protected]> * (fix): push meta files --------- Co-authored-by: qvaleroo <[email protected]>
qvaleroo
added a commit
that referenced
this pull request
Jan 26, 2024
* feat(package)!: the repo is now a unity package (#106) * move every files in correct folder * added & rename asmdef * fix readme * Update package.json * fix: assembly definition * feat!: change the folders architecture * Create .gitignore * feat: update the readme to explain how to install * fix: remove deeplink WIP * fix(versionumber): the updateversionfrompackagejson function should not use a static path (#103) * change to a dynamic path it now use a dynamic path based on the assembly definition * fix: because the folder structure have changed * chore: upgrade version * fix(package): add missing meta files (#112) * Release to download the repo from GitHub URL (#110) * feat(package)!: the repo is now a unity package (#106) * move every files in correct folder * added & rename asmdef * fix readme * Update package.json * fix: assembly definition * feat!: change the folders architecture * Create .gitignore * feat: update the readme to explain how to install * fix: remove deeplink WIP * fix(versionumber): the updateversionfrompackagejson function should not use a static path (#103) * change to a dynamic path it now use a dynamic path based on the assembly definition * fix: because the folder structure have changed * chore: upgrade version --------- Co-authored-by: Morgan - 6 Freedom <[email protected]> * (fix): push meta files --------- Co-authored-by: qvaleroo <[email protected]> --------- Co-authored-by: Morgan - 6 Freedom <[email protected]>
qvaleroo
added a commit
that referenced
this pull request
Feb 19, 2024
* feat(package)!: the repo is now a unity package (#106) * move every files in correct folder * added & rename asmdef * fix readme * Update package.json * fix: assembly definition * feat!: change the folders architecture * Create .gitignore * feat: update the readme to explain how to install * fix: remove deeplink WIP * fix(versionumber): the updateversionfrompackagejson function should not use a static path (#103) * change to a dynamic path it now use a dynamic path based on the assembly definition * fix: because the folder structure have changed * chore: upgrade version * fix(package): add missing meta files (#112) * Release to download the repo from GitHub URL (#110) * feat(package)!: the repo is now a unity package (#106) * move every files in correct folder * added & rename asmdef * fix readme * Update package.json * fix: assembly definition * feat!: change the folders architecture * Create .gitignore * feat: update the readme to explain how to install * fix: remove deeplink WIP * fix(versionumber): the updateversionfrompackagejson function should not use a static path (#103) * change to a dynamic path it now use a dynamic path based on the assembly definition * fix: because the folder structure have changed * chore: upgrade version --------- Co-authored-by: Morgan - 6 Freedom <[email protected]> * (fix): push meta files --------- Co-authored-by: qvaleroo <[email protected]> * fix(promptimage): put all the button in a vertical way * fix(promptimage): update buttons wording * chore(promptimage): put some comments and clean up some code * feat(promptimage): has now a scrollview for the selected image section * chore(promptimage): clean up code * fix(promptimage): some texts were not visible at the end of the scrollable area * feat(promptimage): somes buttons now display messages to the user when using them * feat(promptimage): when clicking on "Set image as ref" it opens the prompt window with Image to Image tab selected * fix(promptimage): selecting another image wasn't resetting the detail panel * chore(promptimage): clean code * fix(121): guidance is now a float * feat(settings): there is a default texture importer and user can change it also move the Settings script in a folder * chore(presets): change the name of the default texture importer and add a default sprite importer * chore(settings): remove unused stuff * fix(promptimage): reset selectedTexture after clearing all images * fix(settings): default preset was not loaded at start * feat(settings): add a sprite preset * chore(commonutils): refactored and renamed some functions about saving images * feat(promptimage): prompt image window now has a download as sprite button * fix(promptimage): the delete button is now at the end * fix(promptwindow): invert the influence value to make more sense and match the webapp - closes #123 (#127) * fix(promptwindow): strengh is now 1-influence * feat(promptwindow): added a tooltip for influence * fix(promptwindow) change max and min value for influence * fix: influence is now between 0 & 99 (and strength between 0.01 & 1.0) * fix(settings): load preset when opening the settings * feat(promptimage): downloaded sprite uses the UsePixelUnits * fix(settings): remove JPG/PNG settings - closes #129 (#130) * fix(settings): remove JPG/PNG settings * fix(settings): fix merge * chore: put everything in the correct namespace * fix(settings): remove image format * chore(tilecreator): wip * fix(tilecreator): merge fix * feat(promptimage): download as sprite - closes #114 (#131) * feat(settings): add a sprite preset * chore(commonutils): refactored and renamed some functions about saving images * feat(promptimage): prompt image window now has a download as sprite button * fix(promptimage): the delete button is now at the end * feat(promptimage): downloaded sprite uses the UsePixelUnits * fix(settings): remove image format * feat(settings): add tiles settings * feat(tilecreator): tiles are added in the tile palette * feat(tilecreator): add a default rectangle tile importer * fix(images): images window is now like the promptimages window * fix(images): improve ui * fix(images): improve UI * fix(images): images are loading now one by one * fix(imagedata): wasn't able to manage progress * feat(images): images window is now able to show generations * chore(promptImage): remove PromptImage scripts * fix(images): action buttons works for images * fix(images): delete button now works * fix(images): delete button now works * fix(images): when doing a new generation, do not reload all images * fix(images): infos were not displayed for recently prompted images * fix(images): delete button wasn't working with recently prompted images * fix(images): the Load More button works only once * fix(images): Download as tile wasn't working * fix: seed wasn't displaying for newly generated images * fix: sampling steps is now an int * fix(images): when removing background, it will also search in the recently prompted images * Update Images.cs * chore(devexp): upgrade version --------- Co-authored-by: Morgan - 6 Freedom <[email protected]> Co-authored-by: Morgan - 6Freedom <[email protected]>
qvaleroo
added a commit
that referenced
this pull request
Mar 18, 2024
* Release 0.5.0 (#140) * feat(package)!: the repo is now a unity package (#106) * move every files in correct folder * added & rename asmdef * fix readme * Update package.json * fix: assembly definition * feat!: change the folders architecture * Create .gitignore * feat: update the readme to explain how to install * fix: remove deeplink WIP * fix(versionumber): the updateversionfrompackagejson function should not use a static path (#103) * change to a dynamic path it now use a dynamic path based on the assembly definition * fix: because the folder structure have changed * chore: upgrade version * fix(package): add missing meta files (#112) * Release to download the repo from GitHub URL (#110) * feat(package)!: the repo is now a unity package (#106) * move every files in correct folder * added & rename asmdef * fix readme * Update package.json * fix: assembly definition * feat!: change the folders architecture * Create .gitignore * feat: update the readme to explain how to install * fix: remove deeplink WIP * fix(versionumber): the updateversionfrompackagejson function should not use a static path (#103) * change to a dynamic path it now use a dynamic path based on the assembly definition * fix: because the folder structure have changed * chore: upgrade version --------- Co-authored-by: Morgan - 6 Freedom <[email protected]> * (fix): push meta files --------- Co-authored-by: qvaleroo <[email protected]> * fix(promptimage): put all the button in a vertical way * fix(promptimage): update buttons wording * chore(promptimage): put some comments and clean up some code * feat(promptimage): has now a scrollview for the selected image section * chore(promptimage): clean up code * fix(promptimage): some texts were not visible at the end of the scrollable area * feat(promptimage): somes buttons now display messages to the user when using them * feat(promptimage): when clicking on "Set image as ref" it opens the prompt window with Image to Image tab selected * fix(promptimage): selecting another image wasn't resetting the detail panel * chore(promptimage): clean code * fix(121): guidance is now a float * feat(settings): there is a default texture importer and user can change it also move the Settings script in a folder * chore(presets): change the name of the default texture importer and add a default sprite importer * chore(settings): remove unused stuff * fix(promptimage): reset selectedTexture after clearing all images * fix(settings): default preset was not loaded at start * feat(settings): add a sprite preset * chore(commonutils): refactored and renamed some functions about saving images * feat(promptimage): prompt image window now has a download as sprite button * fix(promptimage): the delete button is now at the end * fix(promptwindow): invert the influence value to make more sense and match the webapp - closes #123 (#127) * fix(promptwindow): strengh is now 1-influence * feat(promptwindow): added a tooltip for influence * fix(promptwindow) change max and min value for influence * fix: influence is now between 0 & 99 (and strength between 0.01 & 1.0) * fix(settings): load preset when opening the settings * feat(promptimage): downloaded sprite uses the UsePixelUnits * fix(settings): remove JPG/PNG settings - closes #129 (#130) * fix(settings): remove JPG/PNG settings * fix(settings): fix merge * chore: put everything in the correct namespace * fix(settings): remove image format * chore(tilecreator): wip * fix(tilecreator): merge fix * feat(promptimage): download as sprite - closes #114 (#131) * feat(settings): add a sprite preset * chore(commonutils): refactored and renamed some functions about saving images * feat(promptimage): prompt image window now has a download as sprite button * fix(promptimage): the delete button is now at the end * feat(promptimage): downloaded sprite uses the UsePixelUnits * fix(settings): remove image format * feat(settings): add tiles settings * feat(tilecreator): tiles are added in the tile palette * feat(tilecreator): add a default rectangle tile importer * fix(images): images window is now like the promptimages window * fix(images): improve ui * fix(images): improve UI * fix(images): images are loading now one by one * fix(imagedata): wasn't able to manage progress * feat(images): images window is now able to show generations * chore(promptImage): remove PromptImage scripts * fix(images): action buttons works for images * fix(images): delete button now works * fix(images): delete button now works * fix(images): when doing a new generation, do not reload all images * fix(images): infos were not displayed for recently prompted images * fix(images): delete button wasn't working with recently prompted images * fix(images): the Load More button works only once * fix(images): Download as tile wasn't working * fix: seed wasn't displaying for newly generated images * fix: sampling steps is now an int * fix(images): when removing background, it will also search in the recently prompted images * Update Images.cs * chore(devexp): upgrade version --------- Co-authored-by: Morgan - 6 Freedom <[email protected]> Co-authored-by: Morgan - 6Freedom <[email protected]> * Update README.md Add an image to explain how to update the package * chore(devexp): remove release please * chore: modify changelog url --------- Co-authored-by: Morgan - 6 Freedom <[email protected]> Co-authored-by: Morgan - 6Freedom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it now use a dynamic path based on the assembly definition