fix: remove the sliders from the controlnet modes and leave the values the same as in the webapp #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚠ : does this code is able to change the options when the model is a SD1.5 and when the model is a SDXL ? |
Will be done in #125 |
Morgan-6Freedom
approved these changes
Mar 7, 2024
| @@ -36,11 +36,16 @@ public partial class PromptWindowUI | |||
|
|
|||
| public string selectedPreset = ""; | |||
| public int selectedOption1Index = 0; | |||
There was a problem hiding this comment.
maybe rename Option1Name if there is no more 1-2-3-4, etc...
(and also other Something1Variable names)
| public int sliderDisplayedValue = 100; | ||
|
|
||
| /// <summary> | ||
| /// Value from the guidance slider in controlNet options, use to send to generation |
There was a problem hiding this comment.
seems that this value is not only for guidance but that's what the comment is saying
| sliderValue3 = Mathf.Round(EditorGUILayout.Slider(Mathf.Clamp(sliderValue3, 0.1f, 1.0f), 0.1f, 1.0f) * 100) / 100; | ||
| GUILayout.EndHorizontal(); | ||
| { | ||
| GUILayout.Label("Guidance :", EditorStyles.label); |
There was a problem hiding this comment.
I'm not aligned of calling this Guidance and I would prefer Influence. @qvaleroo what do you think ?
Morgan-6Freedom
deleted the
124-remove-the-sliders-from-the-controlnet-modes-and-leave-the-values-the-same-as-in-the-webapp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing other modalities options.
Fix naming on slider and displaying value.