feat!: add quickstart panel and sorting #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morgan-6Freedom
suggested changes
Mar 14, 2024
Morgan-6Freedom
suggested changes
Mar 14, 2024
package/Editor/Models/Models.cs
Outdated
| @@ -12,12 +12,15 @@ public class Models : EditorWindow | |||
|
|
|||
| #region Public Fields | |||
|
|
|||
| public static List<ModelData> modelsQuickStart = new(); | |||
There was a problem hiding this comment.
please add some comments to your newly added Lists
package/Editor/Models/Models.cs
Outdated
| public static List<ModelData> modelsPrivate = new(); | ||
| public static List<ModelData> modelsPublic = new(); | ||
|
|
||
| public static List<TexturePair> texturesQuickStart = new(); |
There was a problem hiding this comment.
please add some comments to your newly added Lists
package/Editor/Models/Models.cs
Outdated
| public static List<TexturePair> texturesPrivate = new(); | ||
| public static List<TexturePair> texturesPublic = new(); | ||
|
|
||
| public static string privacyQuickStart = "quickstart"; |
There was a problem hiding this comment.
please add some comments to your newly added Lists
package/Editor/Models/Models.cs
Outdated
| { | ||
| if (!isProcessing) | ||
| { | ||
| while (true) |
There was a problem hiding this comment.
Why is there a while(true) here ? seems weird / useless
package/Editor/Models/ModelsUI.cs
Outdated
| } | ||
| else | ||
| { | ||
| selectedTab = (IsPrivateTab()) ? 1 : 2; |
There was a problem hiding this comment.
selectedTab seems redundant with privacySettings in Models.cs
This reverts commit 57072f2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding quickstart tab inside models window.
Adding fetching public models with a sorting on "Unity" tag.
Adding some documentation.
Fix some variable naming and serialization.