feat: add quickstart models and sorting #155
Conversation
Adding quickstart tab and sorting models. Adding documentation. Fix some variable naming.
| @@ -12,12 +12,15 @@ public class Models : EditorWindow | |||
|
|
|||
| #region Public Fields | |||
|
|
|||
| public static List<ModelData> modelsQuickStart = new(); | |||
There was a problem hiding this comment.
please add some comments to your newly added Lists
| public static List<ModelData> modelsPrivate = new(); | ||
| public static List<ModelData> modelsPublic = new(); | ||
|
|
||
| public static List<TexturePair> texturesQuickStart = new(); |
There was a problem hiding this comment.
please add some comments to your newly added Lists
| public static List<TexturePair> texturesPrivate = new(); | ||
| public static List<TexturePair> texturesPublic = new(); | ||
|
|
||
| public static string privacyQuickStart = "quickstart"; |
There was a problem hiding this comment.
please add some comments to your newly added Lists
package/Editor/Models/Models.cs
Outdated
| { | ||
| if (!isProcessing) | ||
| { | ||
| while (true) |
There was a problem hiding this comment.
Why is there a while(true) here ? seems weird / useless
There was a problem hiding this comment.
So without this while, is fetching only one page of model.
But I'm agree, and may be we can use thoses lines to:
PaginationTokenPublic = "";
Debug.Log("no next page to fetch.");
To stop the process. I'll check this
There was a problem hiding this comment.
Fix it !
With this fix we also fix another bug, which it was, sometines on redraw or reopening, first models or the first page were in double.
Adding documentations and also only call reloading tabs instead of all the window. This may fix the memory overhead ?
Fix fetching models processing with a better way to stop it. Also remove setting the tab when opening window and only let it inside the OnEnable. Avoid double fetching. With this fix we also fix another bug, which it was, sometines on redraw or reopening first models or the first page was in double.
|
The model screen is not really usable :/ |
|
@qvaleroo can you validate that the last push fix your last comment ? |
|
The last fix forces the quick start to be opened first, but the tab still disappears when I select another one, and the display of models is still chaotic. But it is already the case in production. |
I think there is a subject about memory and SSL connection trouble. |
|
@qvaleroo I merge this one, can you open a bug for the disappearance ? |
Adding quickstart tab and sorting models.
Adding documentation.
Fix some variable naming.