Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compisition camera fix #185

Closed
wants to merge 33 commits into from

Conversation

mrbusysky
Copy link
Collaborator

Fix for #104

I also added some better error logging.

qvaleroo and others added 30 commits February 19, 2024 12:03
* feat(package)!: the repo is now a unity package (scenario-labs#106)

* move every files in correct folder

* added & rename asmdef

* fix readme

* Update package.json

* fix: assembly definition

* feat!: change the folders architecture

* Create .gitignore

* feat: update the readme to explain how to install

* fix: remove deeplink WIP

* fix(versionumber): the updateversionfrompackagejson function should not use a static path (scenario-labs#103)

* change to a dynamic path

it now use a dynamic path based on the assembly definition

* fix: because the folder structure have changed

* chore: upgrade version

* fix(package): add missing meta files (scenario-labs#112)

* Release to download the repo from GitHub URL (scenario-labs#110)

* feat(package)!: the repo is now a unity package (scenario-labs#106)

* move every files in correct folder

* added & rename asmdef

* fix readme

* Update package.json

* fix: assembly definition

* feat!: change the folders architecture

* Create .gitignore

* feat: update the readme to explain how to install

* fix: remove deeplink WIP

* fix(versionumber): the updateversionfrompackagejson function should not use a static path (scenario-labs#103)

* change to a dynamic path

it now use a dynamic path based on the assembly definition

* fix: because the folder structure have changed

* chore: upgrade version

---------

Co-authored-by: Morgan - 6 Freedom <[email protected]>

* (fix): push meta files

---------

Co-authored-by: qvaleroo <[email protected]>

* fix(promptimage): put all the button in a vertical way

* fix(promptimage): update buttons wording

* chore(promptimage): put some comments and clean up some code

* feat(promptimage): has now a scrollview for the selected image section

* chore(promptimage): clean up code

* fix(promptimage): some texts were not visible at the end of the scrollable area

* feat(promptimage): somes buttons now display messages to the user when using them

* feat(promptimage): when clicking on "Set image as ref" it opens the prompt window with Image to Image tab selected

* fix(promptimage): selecting another image wasn't resetting the detail panel

* chore(promptimage): clean code

* fix(121): guidance is now a float

* feat(settings): there is a default texture importer and user can change it

also move the Settings script in a folder

* chore(presets): change the name of the default texture importer and add a default sprite importer

* chore(settings): remove unused stuff

* fix(promptimage): reset selectedTexture after clearing all images

* fix(settings): default preset was not loaded at start

* feat(settings): add a sprite preset

* chore(commonutils): refactored and renamed some functions about saving images

* feat(promptimage): prompt image window now has a download as sprite button

* fix(promptimage): the delete button is now at the end

* fix(promptwindow): invert the influence value to make more sense and match the webapp - closes scenario-labs#123 (scenario-labs#127)

* fix(promptwindow): strengh is now 1-influence

* feat(promptwindow): added a tooltip for influence

* fix(promptwindow) change max and min value for influence

* fix: influence is now between 0 & 99 (and strength between 0.01 & 1.0)

* fix(settings): load preset when opening the settings

* feat(promptimage): downloaded sprite uses the UsePixelUnits

* fix(settings): remove JPG/PNG settings - closes scenario-labs#129 (scenario-labs#130)

* fix(settings): remove JPG/PNG settings

* fix(settings): fix merge

* chore: put everything in the correct namespace

* fix(settings): remove image format

* chore(tilecreator): wip

* fix(tilecreator): merge fix

* feat(promptimage): download as sprite - closes scenario-labs#114 (scenario-labs#131)

* feat(settings): add a sprite preset

* chore(commonutils): refactored and renamed some functions about saving images

* feat(promptimage): prompt image window now has a download as sprite button

* fix(promptimage): the delete button is now at the end

* feat(promptimage): downloaded sprite uses the UsePixelUnits

* fix(settings): remove image format

* feat(settings): add tiles settings

* feat(tilecreator): tiles are added in the tile palette

* feat(tilecreator): add a default rectangle tile importer

* fix(images): images window is now like the promptimages window

* fix(images): improve ui

* fix(images): improve UI

* fix(images): images are loading now one by one

* fix(imagedata): wasn't able to manage progress

* feat(images): images window is now able to show generations

* chore(promptImage): remove PromptImage scripts

* fix(images): action buttons works for images

* fix(images): delete button now works

* fix(images): delete button now works

* fix(images): when doing a new generation, do not reload all images

* fix(images): infos were not displayed for recently prompted images

* fix(images): delete button wasn't working with recently prompted images

* fix(images): the Load More button works only once

* fix(images): Download as tile wasn't working

* fix: seed wasn't displaying for newly generated images

* fix: sampling steps is now an int

* fix(images): when removing background, it will also search in the recently prompted images

* Update Images.cs

* chore(devexp): upgrade version

---------

Co-authored-by: Morgan - 6 Freedom <[email protected]>
Co-authored-by: Morgan - 6Freedom <[email protected]>
Add an image to explain how to update the package
This reverts commit c32111e.
This reverts commit 1876c0d.
@mrbusysky mrbusysky added the bug Something isn't working label Jun 13, 2024
@mrbusysky mrbusysky requested a review from TheLLspectre June 13, 2024 04:04
@mrbusysky mrbusysky self-assigned this Jun 13, 2024
@mrbusysky mrbusysky linked an issue Jun 13, 2024 that may be closed by this pull request
@mrbusysky mrbusysky changed the title Compisition camera fix fix: Compisition camera fix Jun 13, 2024
@mrbusysky mrbusysky changed the title fix: Compisition camera fix fix: compisition camera fix Jun 13, 2024
@mrbusysky mrbusysky changed the base branch from main to develop June 13, 2024 04:50
@mrbusysky mrbusysky requested a review from qvaleroo June 13, 2024 04:51
@mrbusysky mrbusysky closed this Jul 12, 2024
@mrbusysky mrbusysky deleted the CompisitionCameraFix branch July 12, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompositionCamera does not place itself as expected
4 participants