Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming of hasTransferFunction.range property to make its function clear and avoid confusion with minDisplayRange and maxDisplayRange #785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moreApi
Copy link
Member

@moreApi moreApi commented Oct 30, 2024

Improve naming of hasTransferFunction.range property to make its function clear and avoid confusion with minDisplayRange and maxDisplayRange

…ing of range property to make its function clear and avoid confusion with minDisplayRange and maxDisplayRange
@moreApi moreApi changed the title Improve naming of hasTransferfunction.range property to make its function clear and avoid confusion with minDisplayRange and maxDisplayRange Improve naming of hasTransferFunction.range property to make its function clear and avoid confusion with minDisplayRange and maxDisplayRange Oct 30, 2024
@moreApi moreApi requested review from skalarproduktraum and smlpt and removed request for skalarproduktraum October 30, 2024 12:58
Copy link
Contributor

@smlpt smlpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@skalarproduktraum skalarproduktraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moreApi 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants