Support create table as select #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshuldata
reviewed
Sep 26, 2024
| @@ -168,7 +172,9 @@ def test_ctas_with_union(require): | |||
| def execute_via_substrait(connection, query): | |||
| res = connection.get_substrait(query) | |||
| proto_bytes = res.fetchone()[0] | |||
| return connection.from_substrait(proto_bytes) | |||
| con = connection.from_substrait(proto_bytes) | |||
| con.fetchall() # this is needed to force the execution | |||
There was a problem hiding this comment.
I am wondering what will be the behavior when we call it from Gorm (i.e. when we use from icecap). If it is same as this than this needs to be fixed differently. I will spend some time to figure out what will be behavior when we call from_substrait from Gorm
| SELECT name, salary FROM employees""") | ||
|
|
||
| expected = pd.DataFrame({"name": ["John Doe", "Jane Smith", "Alice Johnson", "Bob Brown", "Charlie Black"], | ||
| "salary": [120000.0, 80000, 50000, 95000, 60000]}) |
There was a problem hiding this comment.
imo, since salary is decimal (10,2), we should mention all expected salary values as scale 2 i.e.
[120000.00, 80000.00, 50000.00, 95000.00, 60000.00]
or may be add one of the salary as non zero scale value to make it more clear
|
will open against sundeck-io/duckdb-substrait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.