Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: enable cargo fmt #643

Merged
merged 1 commit into from
Sep 11, 2024
Merged

lint: enable cargo fmt #643

merged 1 commit into from
Sep 11, 2024

Conversation

JakeHillion
Copy link
Contributor

@JakeHillion JakeHillion commented Sep 10, 2024

Use cargo fmt with a specific nightly branch in the CI to enforce formatting. Globally format these files while the diff is still small so we can stay on top of it.

Test plan:

  • CI check passes.

@likewhatevs
Copy link
Contributor

sorry made conflicts merging #644 , will avoid any till this is committed.

@JakeHillion
Copy link
Contributor Author

This is super weird, build-scheds seems to be failing reliably on this PR w/ testing scx_rusty even though the changes to scx_rusty paths are trivial. I'll rebase this in the morning and see if it goes away.

@arighi
Copy link
Contributor

arighi commented Sep 10, 2024

The failure with scx_rusty is due to #610, it has been happening for a while now... so nothing to do with your PR.

@JakeHillion JakeHillion merged commit 8ca45cf into sched-ext:main Sep 11, 2024
2 checks passed
@JakeHillion JakeHillion deleted the rustfmt branch September 11, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants