-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable ide's etc. to work on the bpf.c files #668
enable ide's etc. to work on the bpf.c files #668
Conversation
I also limited edits to those needed to make this work for mitosis, rusty and layered; but this would work with all of them (tested locally). |
will squash when merge -- learned a new thing today (so much nicer than reset soft and push -f repeatedly lol). |
Hey, so, I went through some of it and I'm not sure this is a good idea. For rust, enforcing linting makes sense because everyone does that and each of us is likely to use the same tool to format while working on the code anyway. For C, it's just not that way and I don't think the forced uniformity is worth all that much. The language is not that complex. The statements are expected to be shorter and simpler and there are things going on that the compiler can't make sense of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the other comment.
ed5f155
to
a54cbb2
Compare
a54cbb2
to
368dec7
Compare
Reverted this to what it initially was -- make ide's/lsp work nice on bpf code. An added benefit of this is that we should also get hover docs for comments in functions in common.bpf.h, etc. Will squash merge once approved instead of soft reset and push -f. |
328a28b
to
1ea86d2
Compare
this makes it so that clangd and ide tools which use clangd can work on the bpf.c code. nothing should actually be changed outside of that ide/editor environment, all the changes are ifdef'ed on LSP which is set in the added .clangd file.
1ea86d2
to
1f23048
Compare
* enable ide's etc. to work on the bpf.c files this makes it so that clangd and ide tools which use clangd can work on the bpf.c code. nothing should actually be changed outside of that ide/editor environment, all the changes are ifdef'ed on LSP which is set in the added .clangd file. * move intf include out of both sides of ifdef toggle
this makes it so that clangd and ide tools which use clangd can work on the bpf.c code.
nothing should actually be changed outside of that ide/editor environment, all the changes are ifdef'ed on LSP which is set in the added .clangd file.