Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_layered: Refactor topology algorithms to a separate module #737

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

minosfuture
Copy link
Contributor

This PR addresses #730.

  • scx_layered: Move layer core growth logic to separate module
  • scx_layered: Break up layer_core_order function
    • layer_core_order provided multiple core growth implementation
    • Break it up into smaller function. Also, attach the method to LayerGrowthAlgo. And LayerCoreOrderGenerator is added to make future growth algo extension easy.
  • scx_layered: Add Reverse layer growth algo
    • Add LayerGrowthAlgo::Reverse to be the reverse order of Linear.

Move layer core growth logic to separate module for further refactoring.

Signed-off-by: Ming Yang <[email protected]>
`layer_core_order` provided multiple core growth implementation

Break it up into smaller function. Also, attach the method to
LayerGrowthAlgo. And `LayerCoreOrderGenerator` is added to make future
growth algo extension easy.

Signed-off-by: Ming Yang <[email protected]>
Add `LayerGrowthAlgo::Reverse` to be the reverse order of Linear.

Signed-off-by: Ming Yang <[email protected]>
Copy link
Contributor

@hodgesds hodgesds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hodgesds hodgesds added this pull request to the merge queue Oct 4, 2024
Merged via the queue into sched-ext:main with commit 0eb0a5c Oct 4, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants