Disabling accessor setter when value resolution falls back to the property default value #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joaojacome
commented
Aug 10, 2022
joaojacome
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Doc updated | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #1421 |
| License | MIT |
joaojacome
force-pushed
the
fix-promotion-setter
branch
from
d9ba369
to
47aed2b
Compare
|
@goetas @scyzoryck please review :) |
scyzoryck
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
@joaojacome Thanks for contribution! Do you think that it cause no breaking changes? Should we update documentation for this behavior?
Best, Marcin
|
Hello :) So, the previous MR fixing the default value for constructors had a BC, and this MR is to fix that. BUT, this |
|
@goetas Can you take a look at this one? Thanks! |
|
@joaojacome hi, I will! sorry for the delay |
…perty default value
…perty default value
…perty default value
Signed-off-by: Joao Jacome <[email protected]>
joaojacome
force-pushed
the
fix-promotion-setter
branch
from
4159beb
to
55ae3c6
Compare
|
@goetas any chance you could tag a release? We are currently unable to upgrade beyond 3.17.1 and this PR fixes that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.