Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the codebase #86

Draft
wants to merge 57 commits into
base: master
Choose a base branch
from
Draft

Refactor the codebase #86

wants to merge 57 commits into from

Commits on May 6, 2020

  1. 📝 ORGANIZING_COMPONENTS: Adjust component tree

    @ewen-lbh
    ewen-lbh committed May 6, 2020
    Configuration menu
    Copy the full SHA
    e5b6fdf View commit details
    Browse the repository at this point in the history

  2. ♻️ Add new component files to match the goal component tree

    @ewen-lbh
    ewen-lbh committed May 6, 2020
    Configuration menu
    Copy the full SHA
    0ba8c3f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2020

  1. 🚚 Move old components to ~/components/legacy/

    @ewen-lbh
    ewen-lbh committed May 17, 2020
    Configuration menu
    Copy the full SHA
    b127f58 View commit details
    Browse the repository at this point in the history

  2. 🚧 Create <BaseButton>, <BaseCard> and <ButtonPrimary>

    @ewen-lbh
    ewen-lbh committed May 17, 2020
    Configuration menu
    Copy the full SHA
    ae1abd3 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. 🚧 <ButtonPrimary> Handle [dangerous] *and* [disabled]

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    afac96e View commit details
    Browse the repository at this point in the history

  2. 🚚 Move legacy component tests

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    d37399c View commit details
    Browse the repository at this point in the history

  3. 💄 <ButtonPrimary> Add display: inline-block

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    6b7fc2f View commit details
    Browse the repository at this point in the history

  4. 📝 CONTRIBUTING: Use HTML instead of pug 

    Sure, I _personally_ find pug way cleaner than HTML, but:

* the latter is much more supported and provides better integration in IDEs for .vue files
* it lowers the barrier to entry for people wanting to contribute (few people know pug)
    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    05f1f81 View commit details
    Browse the repository at this point in the history

  5. 🚧 <BaseButton> Centralized [disabled], handle [href]

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    9cd20ab View commit details
    Browse the repository at this point in the history

  6. 💄 material-icons: Convert font-size to ems

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    5d46745 View commit details
    Browse the repository at this point in the history

  7. 🚧 <ButtonSecondary> :active state

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    99ca759 View commit details
    Browse the repository at this point in the history

  8. ♻️ <Button*> extend <BaseButton> instead of redeclaring props

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    4d060cd View commit details
    Browse the repository at this point in the history

  9. ♻️ Put potentially re-usable functions in utils/

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    b85994c View commit details
    Browse the repository at this point in the history

  10. 🐛 validators: Change from ts to js 

    Can't import typescript from javascript
    @ewen-lbh
    ewen-lbh committed May 18, 2020
    Configuration menu
    Copy the full SHA
    94adf16 View commit details
    Browse the repository at this point in the history

  11. 🔧 Add typescript

    @ewen-lbh
    ewen-lbh committed May 18, 2020
    1 Configuration menu
    Copy the full SHA
    bf0d554 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. ♻️ <ButtonIcon> Switch to TS

    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    6eb4c3d View commit details
    Browse the repository at this point in the history

  2. 💄 <ButtonIcon> Handle [small]

    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    051af02 View commit details
    Browse the repository at this point in the history

  3. ✨ Create <SubjectBadge>

    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    e00b3da View commit details
    Browse the repository at this point in the history

  4. 🏷️ <BaseButton> Switch to typescript

    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    e93d746 View commit details
    Browse the repository at this point in the history

  5. ✨ <BaseButton> Handle [href]

    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    458accb View commit details
    Browse the repository at this point in the history

  6. 💄 ^utils: Fix lightColor and darkColor, add blackOrWhite

    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    f5b9cf7 View commit details
    Browse the repository at this point in the history

  7. 🏷️ Add vue-shim.d.ts

    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    2202e93 View commit details
    Browse the repository at this point in the history

  8. 🚧 ♻️ <TimeTable> Refactor from <Schedule> 

    - HTML
- Types
    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    4f88421 View commit details
    Browse the repository at this point in the history

  9. 🚚 Rename <SubjectBadge> to <BadgeSubject>

    @ewen-lbh
    ewen-lbh committed May 19, 2020
    Configuration menu
    Copy the full SHA
    9c47380 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. 🔌 Create <TextLink>, remove link styling from global style rules

    @ewen-lbh
    ewen-lbh committed May 21, 2020
    Configuration menu
    Copy the full SHA
    560c78b View commit details
    Browse the repository at this point in the history

  2. 🔌 Add isIn validator

    @ewen-lbh
    ewen-lbh committed May 21, 2020
    Configuration menu
    Copy the full SHA
    0e19a64 View commit details
    Browse the repository at this point in the history

  3. 🔌 <TextLink> Handle internal & external links properly

    @ewen-lbh
    ewen-lbh committed May 21, 2020
    Configuration menu
    Copy the full SHA
    9753bd0 View commit details
    Browse the repository at this point in the history

  4. 🚧 Start creating <BaseInput>

    @ewen-lbh
    ewen-lbh committed May 21, 2020
    Configuration menu
    Copy the full SHA
    96edc76 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. 📝 CONTRIBUTING: Add section about outer margins on components

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    e7ce25c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactor-2020-05' of https://github.com/schoolsyst/fron… 

    …tend into refactor-2020-05
    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    aedf9e4 View commit details
    Browse the repository at this point in the history

  3. 🐛 <TextLink> Apply noopener, noreferrer to isExternal, not [new-tab]

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    826c22b View commit details
    Browse the repository at this point in the history

  4. 🔧 tsconfig: Temporarily disable libCheck 

    See Akryum/floating-vue#459
    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    a1df55b View commit details
    Browse the repository at this point in the history

  5. 🏷️ <TimeTable> Fix type errors 

    - Renamed API resource types to prefix them with `ApiResource`, since `Event` is a builtin type
- Removed the default value of [event], which was only there for testing anyway, and didn't match the type because it lacked a UUID
- Put some (3) // @ts-ignore comments, one resolvable, the others need a fix from whoever defined `this.$el`'s type
    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    914089e View commit details
    Browse the repository at this point in the history

  6. 💡 <TimeTable> Comment methods.handleEventClick

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    e316274 View commit details
    Browse the repository at this point in the history

  7. 🏷️ <TimeTable> Fix handleHover's typing issue 

    By typecasting `this.$el` to an `HTMLElement`
    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    b6682c8 View commit details
    Browse the repository at this point in the history

  8. ⚗ Create /refactor-test

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    c49c598 View commit details
    Browse the repository at this point in the history

  9. 📝 CONTRIBUTING: Simpler structure for store action functions

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    914cb20 View commit details
    Browse the repository at this point in the history

  10. 🚨 eslint: Warn on camelcase, don't fail with an error 

    The rationale is that the API uses the already well-established snake_case convention, so some variables will inevitably end up snakecase'd
    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    887ca10 View commit details
    Browse the repository at this point in the history

  11. 🏷️ Define types for homework, notes and quizzes

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    8338c66 View commit details
    Browse the repository at this point in the history

  12. 💄 <BadgeSubject> Make the dot smaller

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    d83f5a1 View commit details
    Browse the repository at this point in the history

  13. 🚧 🔌 <BaseButton> Allow any URL

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    744a541 View commit details
    Browse the repository at this point in the history

  14. 🐛 <BaseCard> Make it an importable component, format code

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    898cbd0 View commit details
    Browse the repository at this point in the history

  15. 🐛 <Button*> Forward click events

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    41ca65b View commit details
    Browse the repository at this point in the history

  16. 💄 <ButtonIcon> Remove side padding

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    50aa87f View commit details
    Browse the repository at this point in the history

  17. 🐛 <TextLink> Remove URL validation 

    `isURL` only validates complete URLS -- starting with a protocol. Since <TextLink> also supports internal links, this validator must be removed
    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    ac511a2 View commit details
    Browse the repository at this point in the history

  18. 🚧 Start making <CardHomework>

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    532df24 View commit details
    Browse the repository at this point in the history

  19. 🔧 tsconfig: exclude legacy components

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    32abcf3 View commit details
    Browse the repository at this point in the history

  20. 🔌 validators: Add isUUID

    @ewen-lbh
    ewen-lbh committed May 22, 2020
    Configuration menu
    Copy the full SHA
    70a68e3 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. 🔀 origin/refactor-2020-05 into refactor-2020-05

    @ewen-lbh
    ewen-lbh committed May 24, 2020
    Configuration menu
    Copy the full SHA
    bfc6247 View commit details
    Browse the repository at this point in the history

  2. ♻️ Add <CardAdd>

    @ewen-lbh
    ewen-lbh committed May 24, 2020
    Configuration menu
    Copy the full SHA
    78b0ce7 View commit details
    Browse the repository at this point in the history

  3. ♻️ <BaseCard> Separate border-color from border

    @ewen-lbh
    ewen-lbh committed May 24, 2020
    Configuration menu
    Copy the full SHA
    0b41c57 View commit details
    Browse the repository at this point in the history

  4. ♻️ <CardAdd> Detach from <BaseCard> 

    There was almost nothing in common between the two and some ugly code was required to override <BaseCard>'s styles
    @ewen-lbh
    ewen-lbh committed May 24, 2020
    Configuration menu
    Copy the full SHA
    a069240 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. 🚧 Create heading components

    @ewen-lbh
    ewen-lbh committed May 25, 2020
    Configuration menu
    Copy the full SHA
    0a255f3 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. 💄 <BaseInput> Add styling, allow more [element]s

    @ewen-lbh
    ewen-lbh committed May 27, 2020
    Configuration menu
    Copy the full SHA
    8cc2f1e View commit details
    Browse the repository at this point in the history

  2. 🔌 Create <InputText>

    @ewen-lbh
    ewen-lbh committed May 27, 2020
    Configuration menu
    Copy the full SHA
    8ff5cdf View commit details
    Browse the repository at this point in the history

  3. 💄 <ButtonPrimary> Make [small] version less tall

    @ewen-lbh
    ewen-lbh committed May 27, 2020
    Configuration menu
    Copy the full SHA
    7a5a1a2 View commit details
    Browse the repository at this point in the history

  4. 🚧 🏷️ Started typing & reworking the store 

    Especially index.js, was full of shit that I split into multiple modules in `utils/`
    @ewen-lbh
    ewen-lbh committed May 27, 2020
    Configuration menu
    Copy the full SHA
    a3a3992 View commit details
    Browse the repository at this point in the history