Implement support for month #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Whitespace for changed code was with tabs, should be with spaces. - Also added the compiled test.json result from the base Schybtax project that contains the new tests for dayOfYear.
One of the tests fail.
This was referenced Nov 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bretcope: This PR is almost (but only almost) feature complete.
One of the tests I have added are failing. The test that fails is when I start mixing month() dow() hour() min() and sec(), like e.g. this:
BTW: Might be that the hour/min/sec part isn't needed. Maybe month() dow() triggers this on its own.
The error manifests like this:
I think this is related to code in the IrBuilder.CompileGroup() method, but I am having problems seeing a fix. Maybe you can assist on this?