Rails 7.1 #2431
Merged
Rails 7.1 #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssary for Rails 7.1
…ecord In Rails 7.1 it was creating problems with dup'ing the friendlier_id, I think because Rails 7.1 is better at actually retrieving the database-set friendlier_id This was a messy way to do it anyway, dup'ing ActiveRecord objects is kind of asking for trouble. Factories are the right way to DRY a model in a particular state for test, that's what they're for.
…oller::Parameters instead of Hash
|
Weird
Why have we not encountered that before? But I will do what it says. |
Not sure why it only just now started complaining asking us to do this? We got an error when running on linux, which told us to: bundle lock --add-platform x86_64-linux So we did so
|
Deployed to staging, basic sanity check that it deploys and displays, didn't QA every feature or anything |
|
@eddierubeiz I don't want to merge this until I have more things done on Rails 7.1 -- getting rid of deprecations and such -- but this ready for your approval now! |
eddierubeiz
approved these changes
Nov 13, 2023
|
Done. Thanks for refactoring the test code into the factory too. |
With 'bundle update rails'
Used https://railsdiff.org/7.0.8/7.1.1 to identify, very helpful
…ure why yet It was an oversight we were still on 6.1 and not 7.0 when we moved to Rails 7.0
…on warning when it tries deprecated places. heartcombo/devise#5644
That's all we were using secrets.yml from, we can just set the config from ENV directly, since we aren't putting key in source anyway. In fact, Rails would just pick it up from SECRET_KEY_BASE env even without this, by default? But for consistency with what we did before and clarity, we're going to move it over like this.
…ally take effect In config/initializers, it was happening too late to actually affect our Asset class, so we didn't actually see the new behavior that ended up cauisng us problems
…er_commits to run early enough that we can still work in presence of Rails 7.1 run_after_transaction_callbacks_in_order_defined
This was referenced Nov 21, 2023
Previously on CI, somehow our DB schema _was_ getting loaded... but after moving to Rails 7.1 it wasn't and was causing an error. Not sure what was going on before, but in CI setup script changing 'db:create' to 'db:prepare` tells rails to create the DB _and_ load the schema, and fixes our build
…r, not do things we don't need for CI
…recation Rails 7.1 config and deprecation -- step 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing and working on Rails 7.1, but still with deprecation warnings and other config that needs to be updated.
We'll leave this in draft until that is done in a separate PR, but doing in a separate PR for ease of review.