Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep length normalization for fulltext fields after all. #2435

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Keep length normalization for fulltext fields after all. #2435

merged 1 commit into from
Nov 21, 2023

Conversation

eddierubeiz
Copy link
Contributor

@eddierubeiz eddierubeiz commented Nov 21, 2023 •
edited
Loading

Added some documentation in case we revisit this in the future.

Requires a reindex after deploy, so don't deploy unless you have time to reindex right afterwards.

  • Check this after the PR is in production and the we've reindexed.

Ref #2013

Related PRs:
#2018
#2029

@eddierubeiz eddierubeiz marked this pull request as ready for review November 21, 2023 15:13
@jrochkind
Copy link
Contributor

thanks!

@eddierubeiz eddierubeiz merged commit cf9132c into master Nov 21, 2023
1 check passed
@eddierubeiz eddierubeiz deleted the omitNorms_to_false branch November 21, 2023 15:41
@eddierubeiz
Copy link
Contributor Author

Deployed and reindexed in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrochkind jrochkind jrochkind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddierubeiz @jrochkind