Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Hugo math equation support #589

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

New Hugo math equation support #589

wants to merge 6 commits into from

Conversation

alphapapa
Copy link
Contributor

See #481.

@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited
Loading

✅ Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 59e65c1
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/6628388cd805b000083b4067
😎 Deploy Preview https://deploy-preview-589--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 67
Accessibility: 100
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alphapapa alphapapa marked this pull request as draft April 23, 2024 22:37
@alphapapa alphapapa self-assigned this Apr 23, 2024
@alphapapa
Remove: (layouts/partials/head.html) Empty file
59e65c1 
In accordance with the recommendations in
<https://gohugo.io/content-management/mathematics>, the HTML HEAD
content goes in "baseof.html" rather than here, and after removing the
old implementation, this file is empty.
@alphapapa alphapapa force-pushed the wip/481-kitchen-sink-math branch from 086a539 to 59e65c1 Compare April 23, 2024 22:39
@jarrodmillman
Copy link
Member

I am a little confused about what Hugo actually added. It seems like we still have the same code, but we replace a regular expression to find the embedded math with several lines of configuration. I am not sure this is better than what we had. Sorry, I didn't look carefully at the description of the new feature.

I will take a closer look at this soon and see if it is much better than what we had before or what it gains us.

@alphapapa
Copy link
Contributor Author

Understood, will wait for further instructions. Thanks.

@jarrodmillman
Copy link
Member

It looks like it is mainly adding the pass-through extension.
https://github.com/gohugoio/hugo-goldmark-extensions?tab=readme-ov-file#passthrough-extension
That is worth having I think.

@stefanv
Copy link
Member

stefanv commented Jul 3, 2024

I think using $ as a delimiter is somewhat crucial, and looks like this configuration makes that hard to use: https://gohugo.io/content-management/mathematics/#inline-delimiters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alphapapa alphapapa

Labels
type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alphapapa @jarrodmillman @stefanv