Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SciPy endorsement for SPEC-1 #245

Merged
merged 1 commit into from
Jul 26, 2023
Merged

SciPy endorsement for SPEC-1 #245

merged 1 commit into from
Jul 26, 2023

Conversation

tupui
Copy link
Member

@tupui tupui commented Jul 17, 2023

The discussion on SciPy's mailing list was opened here: https://mail.python.org/archives/list/[email protected]/thread/46PKNGHVQKOKDECMIML7PZCHLKJUKBTA/

Lazy consensus applying, that means we are endorsing. I will send another email to SciPy's list with a week's additional RFC.

rgommers
rgommers previously approved these changes Jul 25, 2023
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Pamphile.

@rgommers rgommers dismissed their stale review July 25, 2023 21:55

mixed up the different SPEC up for approval

@rgommers
Copy link
Contributor

Sorry, I meant to approve SciPy's endorsement of SPECs 0 and 4 instead. For this one, I'd be a lot happier with approving it if it did either use scipy rather than sp or used another package instead. We just chatted about this, and @stefanv has also seen the review comments on the relevant SciPy PR. So please consider either of these options. The lazy import mechanism itself is great, and SciPy uses __getattr__ and __dir__, so from that perspective I'm 👍🏼 on endorsing this too.

stefanv added a commit to stefanv/specs that referenced this pull request Jul 25, 2023
@stefanv
Copy link
Member

stefanv commented Jul 25, 2023

Thanks, Ralf. I agree that aliasing distracts from the SPEC 1 story, so I've filed #250 to remove any mentions of sp.

@bsipocz
Copy link
Member

bsipocz commented Jul 25, 2023

Thanks for removing the aliasing, that removes some explanation nightmares for those of us dealing with over-aliased user code.

@tupui
Copy link
Member Author

tupui commented Jul 26, 2023

I merged the PR, is everyone ok with moving this one?

Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me to merge this now, thanks all!

@tupui
Copy link
Member Author

tupui commented Jul 26, 2023

Great, thanks! Here we go then 🚀

@tupui tupui merged commit f3fad78 into main Jul 26, 2023
2 checks passed
@tupui tupui deleted the spec-1-scipy branch July 26, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants