I817 viewer logic #818
Merged
I817 viewer logic #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overrides logic related to media viewers to prioritize UV in all cases, and fallback to PDFjs as much as possible, regardless of feature flipper setting. Refs - samvera/hyku#2336 - #817 - Clean up views related to media viewers - Better documentation of overrides - Remove duplicated file set indexer decorator
ShanaLMoore
reviewed
Sep 20, 2024
| @@ -1,13 +1,15 @@ | |||
| # frozen_string_literal: true | |||
| # Override Hyku 5 | |||
There was a problem hiding this comment.
Suggested change
| # Override Hyku 5 | |
| # Override Hyku 6 |
ShanaLMoore
reviewed
Sep 20, 2024
| @@ -1,35 +1,55 @@ | |||
| # frozen_string_literal: true | |||
| # Override Hyku 5.0.1 | |||
There was a problem hiding this comment.
Suggested change
| # Override Hyku 5.0.1 | |
| # Override Hyku 6 |
ShanaLMoore
reviewed
Sep 20, 2024
| @@ -1,3 +1,4 @@ | |||
| <%# Override Hyku 5 to send presenter to pdf_js_url method %> | |||
There was a problem hiding this comment.
Suggested change
| <%# Override Hyku 5 to send presenter to pdf_js_url method %> | |
| <%# Override Hyku 6 to send presenter to pdf_js_url method %> |
ShanaLMoore
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Overrides logic related to media viewers to prioritize UV in all
cases, and fallback to PDFjs as much as possible, regardless of
feature flipper setting.
Refs
Other changes:
Expected Behavior Before Changes
Media viewers worked based on flipper flags. Behavior in error situations or during upload process was unexpected.
Based on flipper setting and split status, we see:
Default viewer PDF.js, no split >> shows pdfs viewer
Default viewer: UV, no split >> uses representative_media partial and UV - black box because no split
Default viewer PDF.js, split into child works, >> no viewer, shows default thumbnail
Default viewer: UV, split >> uses UV
Expected Behavior After Changes
Flipper set to PDF.js
Flipper set to UV
Screenshots / Video
Flipper set to PDF.js
Flipper set to UV
Notes