Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Add Campus Features #19

Closed
5 of 9 tasks
Tracked by #2 ...
jillpe opened this issue Aug 22, 2024 · 8 comments
Closed
5 of 9 tasks
Tracked by #2 ...

🎁 Add Campus Features #19

jillpe opened this issue Aug 22, 2024 · 8 comments
Assignees

Comments

@jillpe
Copy link

jillpe commented Aug 22, 2024

Summary

Ask clients for clarification, to fill in the details of this ticket.

Acceptance Criteria

  • TODO: clarify acceptance criteria for campus features
  • Campus features include:

Screenshots or Video

Campus Cards

CAMPUS cards can be seen on the homepage.

Image

image

Facets

image

Breadcrumbs

When you click on a card, the campus can be seen in the breadcrumbs. ie:

Image

image (1)

Testing Instructions

  • Do a catalog search
  • Confirm that the campus facet is showing
  • Click into a collection
  • Confirm that the campus breadcrumb is showing

Notes

Questions:
What is meant by "campus features?"

PR that added the privacy policy to the ngao/production code

PR for original campus cards implementation

@ShanaLMoore
Copy link

they want the campus/repository homepage. should be build in with breadcrumbs.

@ShanaLMoore ShanaLMoore changed the title Privacy Policy and Campus Features 🎁 Add Privacy Policy and Campus Features Aug 22, 2024
@ShanaLMoore ShanaLMoore changed the title 🎁 Add Privacy Policy and Campus Features 🎁 Add Campus Features Aug 23, 2024
@kirkkwang kirkkwang moved this to Ready for Development in indiana-arclight Aug 23, 2024
@kirkkwang kirkkwang moved this from Ready for Development to In Development in indiana-arclight Aug 23, 2024
kirkkwang added a commit that referenced this issue Aug 23, 2024
This will render the campus in the facets field.  All of the changes
came from the current ngao app.

Ref:
- #19
kirkkwang added a commit that referenced this issue Aug 23, 2024
This will render the campus in the facets field.  All of the changes
came from the current ngao app.

Ref:
- #19
kirkkwang added a commit that referenced this issue Aug 24, 2024
This will render the campus in the facets field.  All of the changes
came from the current ngao app.

Ref:
- #19
kirkkwang added a commit that referenced this issue Aug 26, 2024
This will render the campus in the facets field.  All of the changes
came from the current ngao app.

Ref:
- #19
@ShanaLMoore
Copy link

ShanaLMoore commented Aug 26, 2024

ref accessibility review comment: #31 (comment)

  1. Collections page
  • Home breadcrumb does not meet minimum size nor spacing
  • Should be 24 by 24 pixels and it is 37.53 x 18.40 pixels
  1. After searching for “Indiana”
  • 21 elements that need to be resized—does not meet minimum size
  • Breadcrumbs “Indiana (Search text)” and finding aid title are clipped when zoomed in
  • I don’t see this happening, but I think it’s catching that “overflow:hidden” is used in the code, which prevents text from rendering outside of a specific area.
  1. Item view
  • Interactive element doesn’t meet minimum spacing
  • This happened in the Collection Contents sidebar when an item was immediately below the Expand button. There is not enough space around the finding aid item
  1. Item with UV
  • Alt text missing for image in UV
  • Don't think there's anything we can do for this as far as arclight is concerned.

TLDR; there are some minor sizing and spacing issues

Image

kirkkwang added a commit that referenced this issue Aug 26, 2024
This will render the campus in the facets field.  All of the changes
came from the current ngao app.

Ref:
- #19
@ShanaLMoore ShanaLMoore moved this from In Development to SoftServ QA in indiana-arclight Aug 26, 2024
@kirkkwang
Copy link

✅ Passes QA

Image

Image

@brijmcla
Copy link
Collaborator

I'm confused about how campus information is indexing. When I do an empty search and facet by campus, all results are in the campus Indiana University Bloomington. However, all finding aids are within the IUPUI General Collections repository, which is under the campus IUPUI on the homepage. When I open a finding aid, the breadcrumbs display Indiana University>IUPUI General Collections>finding aid title.
campus
campus_facet

@kirkkwang
Copy link

@brijmcla I reindexed, let me know if that looks better

@brijmcla
Copy link
Collaborator

It looks like the Repository search facet was removed at some point between when this ticket was created and now. Did it not play nicely with the Campus facet?

@kirkkwang
Copy link

@brijmcla that's a good catch, i brought a lot of the solr fields over and it didn't match well so I'll fix that. Ex. repository_sim (from the old app) should now be repository_ssim.

@brijmcla
Copy link
Collaborator

Acceptance criteria has been met

@github-project-automation github-project-automation bot moved this from Client QA to Done in indiana-arclight Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants