I19 add campus features #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will add the campus logic to the ead2_config and also change the rake's reference to the app's version.
kirkkwang
force-pushed
the
i19-add-campus-features
branch
from
af01d1e
to
098eccf
Compare
kirkkwang
force-pushed
the
i19-add-campus-features
branch
2 times, most recently
from
a8e4482
to
5159eb5
Compare
kirkkwang
force-pushed
the
i19-add-campus-features
branch
from
5159eb5
to
52ad7a1
Compare
This commit will add relevant SVG files for the breadcrumbs and a few helpers as well as some SolrDocument methods that we'll need. The main thing is adding the Ngao::Arclight::BreadcrumbsHierarchyComponent because we want to override the breadcrumbs_hierarchy_component view. Overriding view component views are a little different that regular view files where if you match the path you'll be set. This required us to create the component object in this application and then it would be able to pick up the overridden view component erb. Ref: - ViewComponent/view_component#411
This is just for the convenience of uncommenting and restarting instead of needing to type it in every time.
This will render the campus in the facets field. All of the changes came from the current ngao app. Ref: - #19
This commit will add the campuses to the index page and do some minimum styling. Also the scroll to top button was added as well all its accompanying files. The repositories.yml was updated to NGAO's current one so we can see more than one campus. We also introduced a decorator pattern to override the repositories controller to add the campus logic.
kirkkwang
force-pushed
the
i19-add-campus-features
branch
from
52ad7a1
to
096fc16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
⚙️ Add campus to ead2_config
619f9af
This commit will add the campus logic to the ead2_config and also change
the rake's reference to the app's version.
🎁 Add campus to breadcrumbs
72b5f47
This commit will add relevant SVG files for the breadcrumbs and a few
helpers as well as some SolrDocument methods that we'll need. The main
thing is adding the Ngao::Arclight::BreadcrumbsHierarchyComponent
because we want to override the breadcrumbs_hierarchy_component view.
Overriding view component views are a little different that regular view
files where if you match the path you'll be set. This required us to
create the component object in this application and then it would be
able to pick up the overridden view component erb.
Ref:
⚙️ Adding a commentted assets debug true
6a1c20d
This is just for the convenience of uncommenting and restarting instead
of needing to type it in every time.
🎁 Add campus to facets
9a17235
This will render the campus in the facets field. All of the changes
came from the current ngao app.
Ref:
🎁 Add campuses to index page
096fc16
This commit will add the campuses to the index page and do some minimum
styling. Also the scroll to top button was added as well all its
accompanying files. The repositories.yml was updated to NGAO's current
one so we can see more than one campus. We also introduced a decorator
pattern to override the repositories controller to add the campus logic.
Expected Behavior Before Changes
Campus was not index and didn't show up on the breadcrumbs. Campus was not a faceted term.
Expected Behavior After Changes
Campus gets indexed and shows up on the breadcrumbs. Campus is now also a faceted term.
Screenshots / Video