🎁 Add new properties to Images work type #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
suggested changes
Nov 17, 2023
| index.as :stored_searchable, :facetable | ||
| end | ||
|
|
||
| property :types, predicate: ::RDF::URI.new("https://atla.com/terms/types") |
There was a problem hiding this comment.
Why are there two :types predicates?
There was a problem hiding this comment.
not really sure, the other work types also have this so i was following the pattern
There was a problem hiding this comment.
I added the comment that I see on the other models where it's defined twice, also asked the team about it here:
https://assaydepot.slack.com/archives/C030UPFB8LW/p1700258300609389
kirkkwang
force-pushed
the
i145-image-work-type
branch
from
ac6a0ad
to
79a047d
Compare
This commit will add new properties to the Images work type. The new properties are: additional_rights_info insitution resource_type types format video_embed Ref: - #145
kirkkwang
force-pushed
the
i145-image-work-type
branch
from
79a047d
to
431b088
Compare
jeremyf
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This commit will add new properties to the Images work type. The new properties are:
additional_rights_info
institution
resource_type
types
format
video_embed
Ref:
Expected Behavior Before Changes
Image work type was just had the default metadata
Expected Behavior After Changes
Image work type has customized metadata
Screenshots / Video
Form
Record