Direct upload of large files #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… external file attaching thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs #534
Expected Behaviour Before Changes
Files >~ 1-1.5GB do not complete upload/attachment when fcrepo backed by s3
Expected Behaviour After Changes
File > 1GB will by-pass fcrepo upload and go direct to s3.
Due to fcrepo/modeshape bug the filesize is not being sent to s3 as metadata and this will cause files to be streamed into memory so larger files will use all the available memory and cause the upload to fail (and sometimes fcrepo to restart).
Working from https://github.com/scientist-softserv/utk-hyku/pull/631/files. This change will mean that files > 1GB will be sent direct to s3 by Hyrax... Then fcrepo object will be created and correctly associated with s3 bitstream as if it had gone via fcrepo.