Fixes PDF splitting for Valkyrie resources #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will move PDF splitting logic to key off of the `on_file_characterized` event. Many of the methods have been updated to work with Valkyrie objects as well.
Universal viewer is still having issues, but that is coming later.
jeremyf
reviewed
Apr 16, 2024
jeremyf
reviewed
Apr 16, 2024
jeremyf
reviewed
Apr 16, 2024
jeremyf
reviewed
Apr 16, 2024
jeremyf
reviewed
Apr 16, 2024
jeremyf
reviewed
Apr 16, 2024
jeremyf
reviewed
Apr 16, 2024
jeremyf
reviewed
Apr 16, 2024
9 tasks
laritakr
force-pushed
the
valkyrie-pdf-split-fix
branch
from
ab2018b
to
243f0f6
Compare
Syntax was incorrect.
laritakr
force-pushed
the
valkyrie-pdf-split-fix
branch
from
243f0f6
to
61e8a74
Compare
Some of the valkyrization work broke child work & fileset indexing for ActiveFedora objects.
ShanaLMoore
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs
To address both Valkyrie and ActiveFedora, a new
child_work_indexermodule was created. This, andfile_set_indexerperform the needed indexing for either Valkyrie or ActiveFedora work types.A listener triggers the splitting as a new file is attached. Additional work is still needed to make the child works' derivatives functional via #350
Expected Behavior Before Changes
PDFs do not split into child works.
Expected Behavior After Changes
PDFs split into child works and parent & children contain appropriate indexed values.
Screenshots
Notes