🐛 Add lonely operator for defensive coding #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lonely operator per Rob's recommendation for defensive coding.
kirkkwang
approved these changes
Jun 18, 2024
ShanaLMoore
added a commit
to samvera/hyku
that referenced
this pull request
Jun 18, 2024
This pulls in a line for defensive coding in lib/iiif_print/base_derivative_service.rb - scientist-softserv/iiif_print#356
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lonely operator per Rob's recommendation for defensive coding, even if, ideally, original_file shouldn't be nil.
We originally noticed an error when running iiif print split locally, from Hyku.