Hide custom terms from resource forms

[laritakr]

Story

This is a partial fix for scientist-softserv/hykuup_knapsack#240 and is tied in with a change in hyrax to support display: false

Expected Behavior Before Changes

IiifPrint custom terms always appear on resource forms.

Expected Behavior After Changes

IiifPrint custom terms can be hidden via yaml display: false in the form definition.

Screenshots / Video

Screenshots

Before

After

Notes

[ShanaLMoore]

I wonder if adding this back will set is_child to false again, instead of nil. cc @laritakr

we need is_child to be true or nil. The catalog query filters out anything that's nil.

if it must be false, I suppose we could update the query but I wonder why it was never set to false from the original implementation.

[ShanaLMoore]

Also ideally we won't update the query because existing applications would need to set their nils to false which may require their data to be reindexed. Unless the query can filter out both 🤔

[ShanaLMoore]

perhaps something like the following will work (untested). I'm not sure how to write a filter query for NOT is_child:true

def show_parents_only(solr_parameters)
  query = if blacklight_params["include_child_works"] == 'true'
            IiifPrint.solr_construct_query(is_child_bsi: 'true')
          else
            "-_query_:\"{!field f=is_child_bsi}true\"" 
          end
  solr_parameters[:fq] += [query]
end

[laritakr]

The term is not present on the parent, so it is nil.
On the child, it is true as expected.
The child works are once again hidden from the catalog search.

be6)